You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by th...@apache.org on 2014/02/08 19:40:06 UTC

[2/2] git commit: TAP5-2275: invalid caching response headers. Adds method Response.addHeader(String, String).

TAP5-2275: invalid caching response headers. Adds method Response.addHeader(String,String).


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/bf714977
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/bf714977
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/bf714977

Branch: refs/heads/master
Commit: bf7149776891371db11f17cd92fb60fce52ca130
Parents: 3a21f85
Author: Thiago H. de Paula Figueiredo <th...@apache.org>
Authored: Sat Feb 8 16:39:43 2014 -0200
Committer: Thiago H. de Paula Figueiredo <th...@apache.org>
Committed: Sat Feb 8 16:39:43 2014 -0200

----------------------------------------------------------------------
 .../tapestry5/internal/ResponseImplTest.java    | 53 ++++++++++++++++++++
 .../kaptcha/components/KaptchaUnitTest.java     | 36 +++++++++++++
 2 files changed, 89 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/bf714977/tapestry-core/src/test/java/org/apache/tapestry5/internal/ResponseImplTest.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/internal/ResponseImplTest.java b/tapestry-core/src/test/java/org/apache/tapestry5/internal/ResponseImplTest.java
new file mode 100644
index 0000000..15d4e6b
--- /dev/null
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/internal/ResponseImplTest.java
@@ -0,0 +1,53 @@
+//  Copyright 2008 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.internal;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.tapestry5.internal.services.ResponseImpl;
+import org.apache.tapestry5.internal.test.InternalBaseTestCase;
+import org.apache.tapestry5.services.Response;
+import org.testng.annotations.Test;
+
+public class ResponseImplTest extends InternalBaseTestCase
+{
+    @Test
+    public void addHeader()
+    {
+        final String HEADER_NAME = "Header-Name";
+        final String[] HEADER_VALUES = {"asdfasdf", "FHDFGH", "####"};
+        
+        final HttpServletResponse httpServletResponse = mockHttpServletResponse();
+        final HttpServletRequest httpServletRequest = mockHttpServletRequest();
+        
+        Response response = new ResponseImpl(httpServletRequest, httpServletResponse);
+        for (String value : HEADER_VALUES)
+        {
+            httpServletResponse.addHeader(HEADER_NAME, value);
+        }
+        
+        replay();
+    
+        for (String value : HEADER_VALUES)
+        {
+            response.addHeader(HEADER_NAME, value);
+        }
+        
+        verify();
+        
+    }
+    
+}

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/bf714977/tapestry-kaptcha/src/test/java/org/apache/tapestry5/kaptcha/components/KaptchaUnitTest.java
----------------------------------------------------------------------
diff --git a/tapestry-kaptcha/src/test/java/org/apache/tapestry5/kaptcha/components/KaptchaUnitTest.java b/tapestry-kaptcha/src/test/java/org/apache/tapestry5/kaptcha/components/KaptchaUnitTest.java
new file mode 100644
index 0000000..849bf00
--- /dev/null
+++ b/tapestry-kaptcha/src/test/java/org/apache/tapestry5/kaptcha/components/KaptchaUnitTest.java
@@ -0,0 +1,36 @@
+// Copyright 2014 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package org.apache.tapestry5.kaptcha.components;
+
+import java.util.List;
+
+import org.apache.tapestry5.internal.test.TestableResponse;
+import org.apache.tapestry5.test.PageTester;
+import org.junit.Test;
+
+public class KaptchaUnitTest
+{
+    
+    @SuppressWarnings("unchecked")
+    @Test
+    public void cache_control_header()
+    {
+        PageTester tester = new PageTester("kaptcha.demo", "app");
+        final TestableResponse response = tester.renderPageAndReturnResponse("KaptchaDemo");
+        final List<String> headers = (List<String>) response.getHeaders("Cache-Control");
+        assert "no-store, no-cache, must-revalidate".equals(headers.get(0));
+        assert "post-check=0, pre-check=0".equals(headers.get(1));
+    }
+
+}