[jira] Commented: (JS2-850) Portlet doesn't return to normal (not maximized) state if it was maximized by edit-defaults mode with maximizeOnEditDefaults option

["Woonsan Ko (JIRA)" <je...@portals.apache.org>]

    [ https://issues.apache.org/jira/browse/JS2-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585375#action_12585375 ] 

Woonsan Ko commented on JS2-850:
--------------------------------

Hi Vitaly,

I looked into this for a while, and I came to the following conclusion:

- It does not seem to be a bug.
  The current portlet decoration supports normalizing the portlet window by view action button in the portlet title bar.
  It is implemented in the way that the portlet URL of the view action button includes both view mode and normal window state. (See o.a.j.decoration.AbstractDecoratorActionsFactory.)
  It could be a workaround to put getActionResponse().setWindowState(WindowState.NORMAL) also. This is the same way to the portlet decoration view action button. 

- I think there is a subtle difference from JS2-806, which issued on keeping nav states in page navigations or not.   I think it is clear to have this option, unlike this issue.
  Should we normalize the window in the maximized edit window? I think it depends on user's choice.
  I think that decorations or portlets can support the user's choice. 
  For decorations, the choice was already implemented, and I think you should put getActionResponse().setWindowState(WindowState.NORMAL) also for your portlets.

> Portlet doesn't return to normal (not maximized) state if it was maximized by edit-defaults mode with maximizeOnEditDefaults option
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JS2-850
>                 URL: https://issues.apache.org/jira/browse/JS2-850
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Customizer, Layout
>    Affects Versions: 2.1.3
>            Reporter: Vitaly Baranovsky
>            Assignee: Woonsan Ko
>
> I've turned on maximizeOnEditDefaults property to true in DecorationValve bean of pipelines.xml. After this portlets doesn't return to normal (not maximized) state if it was maximized by edit-defaults mode.
> Steps to reproduce the bug.
> 1) Get some portlet that has normal state (not maximized nor minimized).
> 2) Press edit-defaults icon
> 3) In edit-defaults mode i press the button that runs the next code:
> getActionResponse().setPortletMode(PortletMode.VIEW);
> 4) After changing portlet mode to VIEW, it's state stays maximized. I think it isn't right, and portlet should change its state to state that was before changing portlet mode to edit_defaults.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org