You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wxbty (via GitHub)" <gi...@apache.org> on 2023/04/27 14:21:36 UTC
[GitHub] [dubbo] wxbty opened a new pull request, #12206: refactor metrics defaultCollector&&agg
wxbty opened a new pull request, #12206:
URL: https://github.com/apache/dubbo/pull/12206
## What is the purpose of the change
Use the same API as the three centers
link https://github.com/apache/dubbo/issues/11941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #12206: refactor metrics defaultCollector&&agg
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #12206:
URL: https://github.com/apache/dubbo/pull/12206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12206: refactor metrics defaultCollector&&agg
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#issuecomment-1527818761
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12206)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [37 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list) [37.6% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on pull request #12206: refactor metrics defaultCollector&&agg
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#issuecomment-1527833056
@AlbumenJ @songxiaosheng PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12206: refactor metrics defaultCollector&&agg
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#issuecomment-1528475559
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12206)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list) [37.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #12206: refactor metrics defaultCollector&&agg
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on code in PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#discussion_r1181141634
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsSupport.java:
##########
@@ -56,4 +73,120 @@ public static Map<String, String> serviceTags(String appAndServiceName) {
tags.put(TAG_INTERFACE_KEY, keys[1]);
return tags;
}
+
+ public static Map<String, String> methodTags(String names) {
+ String[] keys = names.split("_");
+ if (keys.length != 3) {
+ throw new MetricsNeverHappenException("Error names: " + names);
+ }
+ Map<String, String> tags = applicationTags(keys[0]);
+ tags.put(TAG_INTERFACE_KEY, keys[1]);
+ tags.put(TAG_METHOD_KEY, keys[2]);
+ return tags;
+ }
+
+ public static MetricsKey getMetricsKey(RpcException e) {
+ MetricsKey targetKey;
+ targetKey = MetricsKey.METRIC_REQUESTS_FAILED;
+ if (e.isTimeout()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_TIMEOUT;
+ }
+ if (e.isLimitExceed()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_LIMIT;
+ }
+ if (e.isBiz()) {
+ targetKey = MetricsKey.METRIC_REQUEST_BUSINESS_FAILED;
+ }
+ if (e.isSerialization()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_CODEC_FAILED;
+ }
+ if (e.isNetwork()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_NETWORK_FAILED;
+ }
+ return targetKey;
Review Comment:
in the future we also cloud use map to store the relation exception to metric key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12206: refactor metrics defaultCollector&&agg
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#issuecomment-1528824003
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12206)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12206&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL) [32 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12206&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list) [37.9% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12206&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on a diff in pull request #12206: refactor metrics defaultCollector&&agg
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on code in PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#discussion_r1181372037
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsSupport.java:
##########
@@ -56,4 +73,120 @@ public static Map<String, String> serviceTags(String appAndServiceName) {
tags.put(TAG_INTERFACE_KEY, keys[1]);
return tags;
}
+
+ public static Map<String, String> methodTags(String names) {
+ String[] keys = names.split("_");
+ if (keys.length != 3) {
+ throw new MetricsNeverHappenException("Error names: " + names);
+ }
+ Map<String, String> tags = applicationTags(keys[0]);
+ tags.put(TAG_INTERFACE_KEY, keys[1]);
+ tags.put(TAG_METHOD_KEY, keys[2]);
+ return tags;
+ }
+
+ public static MetricsKey getMetricsKey(RpcException e) {
+ MetricsKey targetKey;
+ targetKey = MetricsKey.METRIC_REQUESTS_FAILED;
+ if (e.isTimeout()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_TIMEOUT;
+ }
+ if (e.isLimitExceed()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_LIMIT;
+ }
+ if (e.isBiz()) {
+ targetKey = MetricsKey.METRIC_REQUEST_BUSINESS_FAILED;
+ }
+ if (e.isSerialization()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_CODEC_FAILED;
+ }
+ if (e.isNetwork()) {
+ targetKey = MetricsKey.METRIC_REQUESTS_NETWORK_FAILED;
+ }
+ return targetKey;
Review Comment:
0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #12206: refactor metrics defaultCollector&&agg
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12206:
URL: https://github.com/apache/dubbo/pull/12206#issuecomment-1528489706
## [Codecov](https://codecov.io/gh/apache/dubbo/pull/12206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12206](https://codecov.io/gh/apache/dubbo/pull/12206?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (218800f) into [3.2](https://codecov.io/gh/apache/dubbo/commit/830c460c0a2db7ad6d5caed9a0b7e2890952da77?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (830c460) will **increase** coverage by `0.70%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.2 #12206 +/- ##
============================================
+ Coverage 68.89% 69.60% +0.70%
+ Complexity 341 2 -339
============================================
Files 3547 1598 -1949
Lines 162887 65631 -97256
Branches 26891 9574 -17317
============================================
- Hits 112228 45683 -66545
+ Misses 40870 15549 -25321
+ Partials 9789 4399 -5390
```
[see 2018 files with indirect coverage changes](https://codecov.io/gh/apache/dubbo/pull/12206/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org