You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/03 05:51:37 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #4643: VM dynamic scaling option granularity
harikrishna-patnala opened a new pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
### Description
This PR introduces new granularity levels to configure VM dynamic scalability. Previously VM is configured to be dynamically scalable based on the template and global setting. Now we bringing this option to configure at service offering and VM level also.
VM can dynamically scale only when all flags are ON at VM level, template, service offering and global setting. If any of the flags is set to false then VM cannot be scalable. This result will be persisted in DB for each VM and will be honoured for that VM till it is updated.
We are introducing 'dynamicscalingallowed' parameter with permitted values of true or false for deployVM API and createServiceOffering API.
Following are the API parameter changes:
createServiceOffering API:
dynamicscalingenabled: an optional parameter of type Boolean with default value “true”.
deployVirtualMachine API:
dynamicscalingenabled: an optional parameter of type Boolean with default value “true”.
Following are the UI changes:
Service offering creation has ON/OFF switch for dynamic scaling enabled with default value true.
Deploy VM wizard has ON/OFF switch for dynamic scaling enabled with default value true in Advanced Mode section.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773835496
These failed test cases are commonly seen on all PRs, not related to this PR changes.
test_01_scale_vm on XenServer is failing with License error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849350794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570857656
##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -75,6 +75,9 @@
@Column(name = "deployment_planner")
private String deploymentPlanner = null;
+ @Column(name = "dynamic_scaling_enabled")
+ private boolean dynamicScalingEnabled;
+
Review comment:
is_dynamic is related to custom compute offerings and thats a transient parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775660108
@harikrishna-patnala code LGTM, just check and confirm on the test failures above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-777344088
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773212294
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849413529
I will retest the xen and kvm environments, but I don't consider these errors above to be due to this PR. tested functionality as described. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803861066
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773213085
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-847862309
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849643332
the scaling tests in Travis are due to the template not being marked scalable in the test env. This error seems relted but is happening on other PRs as well so I don't consider it a blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849863756
<b>Trillian test result (tid-762)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36813 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t762-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-846766890
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772254173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r569198673
##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -831,6 +831,7 @@
public static final String CROSS_ZONES = "crossZones";
public static final String TEMPLATETYPE = "templatetype";
public static final String SOURCETEMPLATEID = "sourcetemplateid";
+ public static final String DynamicScalingEnabled = "dynamicscalingenabled";
Review comment:
```suggestion
public static final String DYNAMIC_SCALING_ENABLED = "dynamicscalingenabled";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803855442
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572003114
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm, ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
+ boolean canEnableDynamicScaling = (vm != null? vm.isDynamicallyScalable():true) && offering.isDynamicScalingEnabled() && template.isDynamicallyScalable() && UserVmManager.EnableDynamicallyScaleVm.valueIn(zoneId);
Review comment:
format update _vm != null ? vm.isDynamicallyScalable() : true_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850164585
There is a test failure in the simulator environment, I've fixed it in the last commit. All checks for good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852080647
<b>Trillian Build Failed (tid-815)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773187712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-776460322
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772428354
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4643 (JID-3831)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572149114
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2730,6 +2730,19 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo
if (isDynamicallyScalable == null) {
isDynamicallyScalable = vm.isDynamicallyScalable();
+ } else {
+ if (isDynamicallyScalable == true) {
+ VMTemplateVO template = _templateDao.findByIdIncludingRemoved(vm.getTemplateId());
+ if (!template.isDynamicallyScalable()) {
Review comment:
This is part of updateVirtualMachine API. If no option is provided then we dont have to evaluate the existing dynamic scalability of VM.
If user wants to update the value to "false", meaning VM not to be scalable this implies a kill switch. No need to evaluate the other values at service offering or template or global setting. CS can straight away update the VM.
Only If user wants to update the value to "true" meaning VM to be scalable then CS needs to evaluate whether VM can be marked dynamically scalable based on other options at other granular levels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852056242
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852066081
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-820253982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848701797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772415953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849403733
<b>Trillian test result (tid-756)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47327 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t756-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 83 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 628.16 | test_internal_lb.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 402.25 | test_routers_network_ops.py
test_04_change_offering_small | `Error` | 96.28 | test_service_offerings.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 560.08 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 545.70 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 545.72 | test_vpc_redundant.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 5.45 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803861066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-854960034
<b>Trillian test result (tid-859)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37368 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t859-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-830017738
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571946525
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public Boolean checkIfDynamicScalingCanBeEnabled(ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
Review comment:
VM is separated because first VM deployment will not have VM flag already saved. But I felt putting a null check would simplify the code a bit. Made those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849350794
<b>Trillian test result (tid-755)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41976 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t755-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 77 look OK, 11 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 15.50 | test_diagnostics.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.16 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.15 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.28 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.10 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 462.88 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 469.73 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 469.75 | test_vpc_redundant.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.56 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849863756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849440359
@blueorangutan test centos7 kvm-centos7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803876142
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850334953
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572821981
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
Copy, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850705383
<b>Trillian test result (tid-779)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38400 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t779-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 83.87 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852055913
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r569201241
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -204,6 +204,10 @@
@Param(description = "Root disk size in GB", since = "4.15")
private Long rootDiskSize;
+ @SerializedName("dynamicscalingenabled")
Review comment:
Use the one defined in ApiConstants here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-802844262
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848701797
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-777344459
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850243650
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773186872
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570806371
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -223,6 +223,11 @@
@Parameter(name = ApiConstants.STORAGE_POLICY, type = CommandType.UUID, entityType = VsphereStoragePoliciesResponse.class,required = false, description = "Name of the storage policy defined at vCenter, this is applicable only for VMware", since = "4.15")
private Long storagePolicy;
+ @Parameter(name = ApiConstants.DYNAMIC_SCALING_ENABLED,
+ type = CommandType.BOOLEAN,
+ description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
+ protected Boolean isDynamicScalingEnabled;
+
Review comment:
@harikrishna-patnala we probably want to add the since attribute to any new parameters added to the APIs?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
Review comment:
@harikrishna-patnala is there a reason that we've set it to true as opposed to find the value from the service offering?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
} else {
if (zone.isSecurityGroupEnabled()) {
vm = _userVmService.createAdvancedSecurityGroupVirtualMachine(zone, serviceOffering, template, null, null,
owner, "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null,
- null, null, true, null, null, null, null, null, null, null);
+ null, null, true, null, null, null, null, null, null, null, true);
Review comment:
same as above
##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -75,6 +75,9 @@
@Column(name = "deployment_planner")
private String deploymentPlanner = null;
+ @Column(name = "dynamic_scaling_enabled")
+ private boolean dynamicScalingEnabled;
+
Review comment:
@harikrishna-patnala what's the difference between "dynamic_scaling_enabled" vs "is_dynamic" field?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
} else {
if (zone.isSecurityGroupEnabled()) {
vm = _userVmService.createAdvancedSecurityGroupVirtualMachine(zone, serviceOffering, template, null, null,
owner, "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null,
- null, null, true, null, null, null, null, null, null, null);
+ null, null, true, null, null, null, null, null, null, null, true);
} else {
vm = _userVmService.createAdvancedVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(), "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
- null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null, addrs, true, null, null, null, null, null, null, null);
+ null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null, addrs, true, null, null, null, null, null, null, null, true);
Review comment:
same as above
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ private Boolean checkIfDynamicScalingCanBeEnabled(Boolean dynamicScalingEnabled, ServiceOfferingVO offering, VMTemplateVO template, Long zoneId) {
Review comment:
can we not define this in UserVMManager and call this method at all other places where the check is repeated - eg. at KubernetesClusterStartWorker and other classes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571945677
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
fixed all Boolean to boolean, thanks for that.
Yes all old service offerings prior to upgrade will be marked as dynamically scalable. This is made not to break existing VMs because service offering was not part of dynamic scaling decision before. After upgrade we need to bypass that check for old VMs, which can be achieved by marking them true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572139690
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
1. parameter on template registration is purely a property of a template which defines whether template has hypervisor supported tools installed or not. It is not an option. So default is assumed to be "false". If tools are installed on template then admin will mark it explicitly to "true".
2. default value of global setting is also set to "false" assuming admin will enable the feature if they want overall on CloudStack management zones.
3. When coming to VM or Service offering, these are options to enable or disable at VM level. Given a template is dynamically scalable and global setting is set to true, User can still have option to decide whether he/she wants the VM to dynamically scalable or not. Defaulted to "true" because by if no option is given when deploying the VM then it adheres the template property and global setting by admin. If we default it to "false" and User did not set any option then even though the template is dynamically scalable and global setting is "true", VM cannot scale.
In summary VM can be scalable only when all options are true. Any parameter setting to "false" will make the VM not dynamically scalable. Each parameter acts as kill switch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571999553
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2730,6 +2730,19 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo
if (isDynamicallyScalable == null) {
isDynamicallyScalable = vm.isDynamicallyScalable();
+ } else {
+ if (isDynamicallyScalable == true) {
+ VMTemplateVO template = _templateDao.findByIdIncludingRemoved(vm.getTemplateId());
+ if (!template.isDynamicallyScalable()) {
Review comment:
below checks will be missed for the updated `isDynamicallyScalable` when "isDynamicallyScalable == null"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772415337
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773639802
<b>Trillian test result (tid-3492)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39835 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3492-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 778.21 | test_kubernetes_clusters.py
test_change_service_offering_for_vm_with_snapshots | `Error` | 140.93 | test_vm_snapshots.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803860556
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850257494
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775270708
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572003114
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm, ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
+ boolean canEnableDynamicScaling = (vm != null? vm.isDynamicallyScalable():true) && offering.isDynamicScalingEnabled() && template.isDynamicallyScalable() && UserVmManager.EnableDynamicallyScaleVm.valueIn(zoneId);
Review comment:
formatting update _vm != null ? vm.isDynamicallyScalable() : true_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-820301535
<b>Trillian Build Failed (tid-450)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850297252
<b>Trillian Build Failed (tid-773)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852065529
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571992645
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
The default value is false, for the global setting "_enable.dynamic.scale.vm_" and parameter "_isdynamicallyscalable_" in registerTemplate/ISO call , defined earlier. Any reason, to make default as "True" here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r569200562
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -475,4 +478,12 @@ public void setVsphereStoragePolicy(String vsphereStoragePolicy) {
public void setRootDiskSize(Long rootDiskSize) {
this.rootDiskSize = rootDiskSize;
}
+
+ public Boolean getDynamicscalingenabled() {
Review comment:
```suggestion
public Boolean getDynamicScalingEnabled() {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-777368890
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-820253982
<b>Trillian Build Failed (tid-449)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-805358891
<b>Trillian test result (tid-231)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35496 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t231-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 78.45 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.14 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r623793865
##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -105,64 +108,22 @@ public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer spee
this.vmType = vmType == null ? null : vmType.toString().toLowerCase();
}
- public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA, boolean limitCpuUse,
- boolean volatileVm, String displayText, ProvisioningType provisioningType, boolean useLocalStorage, boolean recreatable, String tags, boolean systemUse, VirtualMachine.Type vmType) {
+ public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA,
+ boolean limitResourceUse, boolean volatileVm, String displayText, ProvisioningType provisioningType, boolean useLocalStorage, boolean recreatable, String tags, boolean systemUse,
+ VirtualMachine.Type vmType, String hostTag, String deploymentPlanner, Boolean dynamicScalingEnabled) {
super(name, displayText, provisioningType, false, tags, recreatable, useLocalStorage, systemUse, true);
this.cpu = cpu;
this.ramSize = ramSize;
this.speed = speed;
this.rateMbps = rateMbps;
this.multicastRateMbps = multicastRateMbps;
this.offerHA = offerHA;
- this.limitCpuUse = limitCpuUse;
+ this.limitCpuUse = limitResourceUse;
Review comment:
There are some unused constructors, so this is the result of removing/clubbing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850901624
<b>Trillian test result (tid-788)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33951 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t788-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849290832
<b>Trillian test result (tid-754)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t754-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850743611
<b>Trillian test result (tid-774)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56808 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t774-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 512.70 | test_internal_lb.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 647.77 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 673.31 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 615.58 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 472.88 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850762941
<b>Trillian test result (tid-776)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 62127 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t776-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 51 look OK, 26 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_public_ip_admin_account | `Failure` | 32.21 | test_network.py
test_public_ip_user_account | `Failure` | 2.14 | test_network.py
test_reboot_router | `Failure` | 419.54 | test_network.py
test_releaseIP | `Failure` | 671.08 | test_network.py
test_05_ping_in_cpvm_success | `Failure` | 4.12 | test_diagnostics.py
test_02_vpc_privategw_static_routes | `Failure` | 167.79 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 141.20 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 348.00 | test_privategw_acl.py
test_UpdateConfigParamWithScope | `Error` | 0.16 | test_global_settings.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.34 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.31 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.31 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.32 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.15 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.23 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.54 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume | `Error` | 1.18 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 1.13 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 35.53 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 123.24 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 79.37 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 79.37 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 119.44 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.57 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 163.12 | test_host_maintenance.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.00 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848701381
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775065360
@sureshanaparti @Pearl1594 @nvazquez I've addressed your comments and updated the code as per the suggestions. Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-802844262
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala closed pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849643332
the scaling tests in Travis are due to the template not being marked scalable in the test env. This error seems relted but is happening on other PRs as well so I don't consider it a blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850738040
<b>Trillian test result (tid-781)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46248 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t781-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 84 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 408.11 | test_routers_network_ops.py
test_04_change_offering_small | `Failure` | 920.45 | test_service_offerings.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 653.79 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 563.20 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 615.28 | test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 17.66 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 6.67 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-804802177
<b>Trillian Build Failed (tid-222)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803807107
> @harikrishna-patnala can you address the conflicts, please?
Resolved conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572153290
##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -240,7 +239,7 @@ protected VirtualMachineTO toVirtualMachineTO(VirtualMachineProfile vmProfile) {
// Workaround to make sure the TO has the UUID we need for Niciri integration
VMInstanceVO vmInstance = _virtualMachineDao.findById(to.getId());
// check if XStools/VMWare tools are present in the VM and dynamic scaling feature is enabled (per zone/global)
- Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable() && UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId());
+ Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable();
Review comment:
During VM deployment when VM entry is persisted, VM's dynamic scalability is evaluated based on all options user input, template, service offering and global setting. So no need to check with global setting while preparing the transfer object.
Removing the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773211211
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849439619
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775297161
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775651521
<b>Trillian test result (tid-3514)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38210 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3514-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 801.70 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-777344459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803807286
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-846752661
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849290832
<b>Trillian test result (tid-754)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t754-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852055131
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803807874
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773836392
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772254173
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571993333
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -623,6 +627,10 @@ public Boolean getBootIntoSetup() {
return bootIntoSetup;
}
+ public boolean isDynamicScalingEnabled() {
+ return dynamicScalingEnabled == null ? true : dynamicScalingEnabled;
Review comment:
Same here as well, reason to make default as "True" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772415953
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-804802045
<b>Trillian Build Failed (tid-221)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775107698
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848974520
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850297252
<b>Trillian Build Failed (tid-773)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-776459913
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-830017245
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850920728
<b>Trillian test result (tid-787)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46537 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t787-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 84 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 55.04 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 37.91 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 48.64 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 42.92 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 35.77 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 48.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 49.62 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 35.82 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 128.03 | test_kubernetes_clusters.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 382.58 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 606.07 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 606.09 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 533.64 | test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1629.41 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773585520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772253592
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849439021
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775270708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850136495
<b>Trillian test result (tid-763)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 72997 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t763-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 12 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 370.64 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.12 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 399.75 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 505.79 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala closed pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773186872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r569200750
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -475,4 +478,12 @@ public void setVsphereStoragePolicy(String vsphereStoragePolicy) {
public void setRootDiskSize(Long rootDiskSize) {
this.rootDiskSize = rootDiskSize;
}
+
+ public Boolean getDynamicscalingenabled() {
+ return dynamicscalingenabled;
+ }
+
+ public void setDynamicscalingenabled(Boolean dynamicscalingenabled) {
Review comment:
```suggestion
public void setDynamicScalingEnabled(Boolean dynamicscalingenabled) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850817553
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850342821
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570860401
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
Review comment:
this parameter value in deploy VM flow is the one that read from deploy VM API, where as in other cases there is no user/admin option to specify whether the VM can be dynamically scalable or not, so it is defaulted to true. All these method calls will reach checkIfDynamicScalingCanBeEnabled() where other dynamic scaling flags from template, offering and global setting are considered.
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ private Boolean checkIfDynamicScalingCanBeEnabled(Boolean dynamicScalingEnabled, ServiceOfferingVO offering, VMTemplateVO template, Long zoneId) {
Review comment:
Just realised check at KubernetesClusterStartWorker class is redundant one, I'll remove that and also try to use a common method in other classes. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r569200939
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -204,6 +204,10 @@
@Param(description = "Root disk size in GB", since = "4.15")
private Long rootDiskSize;
+ @SerializedName("dynamicscalingenabled")
+ @Param(description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
+ private Boolean dynamicscalingenabled;
Review comment:
```suggestion
private Boolean dynamicScalingEnabled;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850920728
<b>Trillian test result (tid-787)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46537 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t787-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 84 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 55.04 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 37.91 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 48.64 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 42.92 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 35.77 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 48.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 49.62 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 35.82 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 128.03 | test_kubernetes_clusters.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 382.58 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 606.07 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 606.09 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 533.64 | test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1629.41 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572165466
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm, ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
+ boolean canEnableDynamicScaling = (vm != null? vm.isDynamicallyScalable():true) && offering.isDynamicScalingEnabled() && template.isDynamicallyScalable() && UserVmManager.EnableDynamicallyScaleVm.valueIn(zoneId);
Review comment:
Addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572001777
##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -240,7 +239,7 @@ protected VirtualMachineTO toVirtualMachineTO(VirtualMachineProfile vmProfile) {
// Workaround to make sure the TO has the UUID we need for Niciri integration
VMInstanceVO vmInstance = _virtualMachineDao.findById(to.getId());
// check if XStools/VMWare tools are present in the VM and dynamic scaling feature is enabled (per zone/global)
- Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable() && UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId());
+ Boolean isDynamicallyScalable = vmInstance.isDynamicallyScalable();
Review comment:
where this global setting value "_UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId())_" is being checked now ? Please update the above comment appropriately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775300679
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-852094782
<b>Trillian Build Failed (tid-814)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850257680
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571996626
##########
File path: engine/schema/src/main/java/com/cloud/vm/VMInstanceVO.java
##########
@@ -57,7 +57,8 @@
@Table(name = "vm_instance")
@Inheritance(strategy = InheritanceType.JOINED)
@DiscriminatorColumn(name = "type", discriminatorType = DiscriminatorType.STRING, length = 32)
-public class VMInstanceVO implements VirtualMachine, FiniteStateObject<State, VirtualMachine.Event> {
+public class
Review comment:
extra white space here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-849440979
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848974520
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773587284
<b>Trillian test result (tid-3490)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33415 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3490-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 11.62 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-830028204
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775269951
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775622537
<b>Trillian test result (tid-3512)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33403 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3512-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 9.31 | test_scale_vm.py
test_01_vpc_site2site_vpn | `Failure` | 272.17 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850243650
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772275918
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-777344088
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803807286
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775080982
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-776459913
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848439881
<b>Trillian test result (tid-737)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49630 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t737-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_reboot_router | `Failure` | 445.76 | test_network.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3613.38 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3613.45 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 98.92 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850743611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773585520
<b>Trillian test result (tid-3491)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33095 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3491-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775663901
Thanks @sureshanaparti.
Test failures are not related this PR changes and are common on all other PRs.
test_01_scale_vm on XenServer is failing with License issues. So I've manually ran it on my setup to check the actual result and it passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850319898
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-846753257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-847863275
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572584142
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
Ok @harikrishna-patnala thanks for the detailed explanation. Assuming the same is updated in the CS documentation (wherever required).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850666720
<b>Trillian Build Failed (tid-772)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850319427
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850697840
<b>Trillian test result (tid-780)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36958 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t780-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570806371
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -223,6 +223,11 @@
@Parameter(name = ApiConstants.STORAGE_POLICY, type = CommandType.UUID, entityType = VsphereStoragePoliciesResponse.class,required = false, description = "Name of the storage policy defined at vCenter, this is applicable only for VMware", since = "4.15")
private Long storagePolicy;
+ @Parameter(name = ApiConstants.DYNAMIC_SCALING_ENABLED,
+ type = CommandType.BOOLEAN,
+ description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
+ protected Boolean isDynamicScalingEnabled;
+
Review comment:
@harikrishna-patnala we probably want to add the since attribute to any new parameters added to the APIs?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
Review comment:
@harikrishna-patnala is there a reason that we've set it to true as opposed to find the value from the service offering?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
} else {
if (zone.isSecurityGroupEnabled()) {
vm = _userVmService.createAdvancedSecurityGroupVirtualMachine(zone, serviceOffering, template, null, null,
owner, "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null,
- null, null, true, null, null, null, null, null, null, null);
+ null, null, true, null, null, null, null, null, null, null, true);
Review comment:
same as above
##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -75,6 +75,9 @@
@Column(name = "deployment_planner")
private String deploymentPlanner = null;
+ @Column(name = "dynamic_scaling_enabled")
+ private boolean dynamicScalingEnabled;
+
Review comment:
@harikrishna-patnala what's the difference between "dynamic_scaling_enabled" vs "is_dynamic" field?
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm = _userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null, true);
} else {
if (zone.isSecurityGroupEnabled()) {
vm = _userVmService.createAdvancedSecurityGroupVirtualMachine(zone, serviceOffering, template, null, null,
owner, "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null,
- null, null, true, null, null, null, null, null, null, null);
+ null, null, true, null, null, null, null, null, null, null, true);
} else {
vm = _userVmService.createAdvancedVirtualMachine(zone, serviceOffering, template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(), "autoScaleVm-" + asGroup.getId() + "-" + getCurrentTimeStampString(),
- null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null, addrs, true, null, null, null, null, null, null, null);
+ null, null, null, HypervisorType.XenServer, HTTPMethod.GET, null, null, null, addrs, true, null, null, null, null, null, null, null, true);
Review comment:
same as above
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ private Boolean checkIfDynamicScalingCanBeEnabled(Boolean dynamicScalingEnabled, ServiceOfferingVO offering, VMTemplateVO template, Long zoneId) {
Review comment:
can we not define this in UserVMManager and call this method at all other places where the check is repeated - eg. at KubernetesClusterStartWorker and other classes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775107698
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850817587
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-854955142
<b>Trillian test result (tid-858)</b>
Environment: xenserver-72 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37475 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t858-xenserver-72.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775616264
<b>Trillian test result (tid-3513)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32281 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3513-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775080491
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773213085
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-775301383
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-804802045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-776477028
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570935615
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -223,6 +223,11 @@
@Parameter(name = ApiConstants.STORAGE_POLICY, type = CommandType.UUID, entityType = VsphereStoragePoliciesResponse.class,required = false, description = "Name of the storage policy defined at vCenter, this is applicable only for VMware", since = "4.15")
private Long storagePolicy;
+ @Parameter(name = ApiConstants.DYNAMIC_SCALING_ENABLED,
+ type = CommandType.BOOLEAN,
+ description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
+ protected Boolean isDynamicScalingEnabled;
+
Review comment:
Added since attribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848717088
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850257680
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850342510
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-803807874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r598684071
##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -105,64 +108,22 @@ public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer spee
this.vmType = vmType == null ? null : vmType.toString().toLowerCase();
}
- public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA, boolean limitCpuUse,
- boolean volatileVm, String displayText, ProvisioningType provisioningType, boolean useLocalStorage, boolean recreatable, String tags, boolean systemUse, VirtualMachine.Type vmType) {
+ public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA,
+ boolean limitResourceUse, boolean volatileVm, String displayText, ProvisioningType provisioningType, boolean useLocalStorage, boolean recreatable, String tags, boolean systemUse,
+ VirtualMachine.Type vmType, String hostTag, String deploymentPlanner, Boolean dynamicScalingEnabled) {
super(name, displayText, provisioningType, false, tags, recreatable, useLocalStorage, systemUse, true);
this.cpu = cpu;
this.ramSize = ramSize;
this.speed = speed;
this.rateMbps = rateMbps;
this.multicastRateMbps = multicastRateMbps;
this.offerHA = offerHA;
- this.limitCpuUse = limitCpuUse;
+ this.limitCpuUse = limitResourceUse;
Review comment:
why this rename?
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
@harikrishna-patnala and @nvazquez this method is `Boolean` was it meant to become `boolean`?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java
##########
@@ -204,6 +204,10 @@
@Param(description = "Root disk size in GB", since = "4.15")
private Long rootDiskSize;
+ @SerializedName(ApiConstants.DYNAMIC_SCALING_ENABLED)
+ @Param(description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
Review comment:
```suggestion
@Param(description = "true if virtual machine needs to be dynamically scalable of cpu or memory", @since="4.16")
```
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -7045,13 +7072,18 @@ public UserVm restoreVirtualMachine(final Account caller, final long vmId, final
vm.setIsoId(newTemplateId);
vm.setGuestOSId(template.getGuestOSId());
vm.setTemplateId(newTemplateId);
- _vmDao.update(vmId, vm);
} else {
newVol = volumeMgr.allocateDuplicateVolume(root, newTemplateId);
vm.setGuestOSId(template.getGuestOSId());
vm.setTemplateId(newTemplateId);
- _vmDao.update(vmId, vm);
}
+ // check if VM can be dynamically scalable with the new template
+ ServiceOfferingVO serviceOffering = _offeringDao.findById(vm.getServiceOfferingId());
+ VMTemplateVO newTemplate = _templateDao.findById(newTemplateId);
+ boolean dynamicScalingEnabled = checkIfDynamicScalingCanBeEnabled(vm, serviceOffering, newTemplate, vm.getDataCenterId());
+ vm.setDynamicallyScalable(dynamicScalingEnabled);
+ _vmDao.update(vmId, vm);
+
Review comment:
can you extract this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-846753257
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850257494
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850697840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-772420252
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4643 (JID-3830)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-850738040
<b>Trillian test result (tid-781)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46248 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t781-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 84 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 408.11 | test_routers_network_ops.py
test_04_change_offering_small | `Failure` | 920.45 | test_service_offerings.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 653.79 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 563.20 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 615.28 | test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 17.66 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 6.67 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848974238
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848395303
<b>Trillian test result (tid-736)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41906 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t736-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773187712
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571438409
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -623,6 +627,10 @@ public Boolean getBootIntoSetup() {
return bootIntoSetup;
}
+ public Boolean isDynamicScalingEnabled() {
+ return dynamicScalingEnabled == null ? Boolean.TRUE : dynamicScalingEnabled;
Review comment:
Same as above
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE : isDynamicScalingEnabled;
Review comment:
As the null check is in place, what about returning boolean instead of Boolean on this function? Also, this will mean that all the service offerings registered before 4.16 will now become dynamically scallable as well?
##########
File path: engine/schema/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/db/VMEntityVO.java
##########
@@ -561,6 +564,11 @@ public boolean isDisplay() {
return display;
}
+ @Override
+ public Boolean isDynamicallyScalable() {
Review comment:
This can return a boolean as well
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,16 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
return vm;
}
+ @Override
+ public Boolean checkIfDynamicScalingCanBeEnabled(ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
Review comment:
Can this method also accept a VM as a parameter and check if the VM is scalable as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-802891320
@harikrishna-patnala can you address the conflicts, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala closed pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4643: VM dynamic scaling option granularity
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-776460322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org