You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/25 07:06:10 UTC

[GitHub] [incubator-mxnet] Alicia1529 opened a new pull request #17905: [Numpy] add op unpackbits

Alicia1529 opened a new pull request #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905
 
 
   ## Description ##
   add op unpackbits
   
   
   Old FFI (ctypes) (us) | New FFI (cython) (us)
   -- | --
   unpackbits | 0.94 | 9.27
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603785248
 
 
   @mxnet-bot run ci [windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614593810
 
 
   Jenkins CI successfully triggered : [windows-gpu, windows-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612731598
 
 
   Jenkins CI successfully triggered : [centos-gpu, unix-gpu, windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603740992
 
 
   Jenkins CI successfully triggered : [windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603676792
 
 
   Hey @Alicia1529 , Thanks for submitting the PR 
   Once your PR is ready for CI checks, invoke the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, website, unix-gpu, edge, centos-cpu, windows-cpu, miscellaneous, sanity, unix-cpu, centos-gpu, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603981267
 
 
   Unauthorized access detected. 
   Only following 3 categories can trigger CI : 
   PR Author, MXNet Committer, Jenkins Admin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612571255
 
 
   @mxnet-bot run ci [windows-gpu, centos-gpu, unix-cpu, unix-gpu, centos-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-611825561
 
 
   @mxnet-bot run ci [windows-gpu, centos-gpu, unix-cpu, unix-gpu, macosx-x86_64]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614395720
 
 
   @mxnet-bot run ci [windows-gpu, windows-cpu, unix-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614593754
 
 
   @mxnet-bot run ci [windows-gpu, windows-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614450533
 
 
   @mxnet-bot run ci [windows-gpu, windows-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614689417
 
 
   @mxnet-bot run ci [windows-gpu, windows-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614395774
 
 
   Jenkins CI successfully triggered : [unix-cpu, windows-cpu, windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612600005
 
 
   Jenkins CI successfully triggered : [windows-gpu, unix-gpu, centos-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612599990
 
 
   @mxnet-bot run ci [windows-gpu, centos-gpu, unix-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603740927
 
 
   @mxnet-bot run ci [windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603785312
 
 
   Jenkins CI successfully triggered : [windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-611825600
 
 
   Jenkins CI successfully triggered : [centos-gpu, windows-gpu, unix-gpu, unix-cpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
haojin2 commented on a change in pull request #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#discussion_r404528509
 
 

 ##########
 File path: python/mxnet/symbol/numpy/_symbol.py
 ##########
 @@ -6799,6 +6799,56 @@ def bincount(x, weights=None, minlength=0):
     return _npi.bincount(x, weights=weights, minlength=minlength, has_weights=True)
 
 
+@set_module('mxnet.symbol.numpy')
+def unpackbits(a, axis=None, count=None, bitorder='big'):
+    """
+    unpackbits(a, axis=None, count=None, bitorder='big')
+
+    Unpacks elements of a uint8 array into a binary-valued output array.
+
+    Each element of `a` represents a bit-field that should be unpacked
+    into a binary-valued output array. The shape of the output array is
+    either 1-D (if `axis` is ``None``) or the same shape as the input
+    array with unpacking done along the axis specified.
+
+    Parameters
+    ----------
+    a : ndarray, uint8 type
+       Input array.
+    axis : int, optional
+        The dimension over which bit-unpacking is done.
+        ``None`` implies unpacking the flattened array.
+    count : int or None, optional (not supported at this moment)
+        The number of elements to unpack along `axis`, provided as a way
+        of undoing the effect of packing a size that is not a multiple
+        of eight. A non-negative number means to only unpack `count`
+        bits. A negative number means to trim off that many bits from
+        the end. ``None`` means to unpack the entire array (the
+        default). Counts larger than the available number of bits will
+        add zero padding to the output. Negative counts must not
+        exceed the available number of bits.
+
+    bitorder : {'big', 'little'}, optional
+        The order of the returned bits. 'big' will mimic bin(val),
+        ``3 = 0b00000011 => [0, 0, 0, 0, 0, 0, 1, 1]``, 'little' will reverse
+        the order to ``[1, 1, 0, 0, 0, 0, 0, 0]``.
+        Defaults to 'big'.
+
+    Returns
+    -------
+    unpacked : ndarray, uint8 type
 
 Review comment:
   `unpacked : _Symbol`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614695824
 
 
   Looks like you have had to retrigger windows builds number of times because of #18015 
   @haojin2 @Alicia1529 do you want to tweak the tolerance so that the restriction isn't tight?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-603981226
 
 
   @mxnet-bot run ci [windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] Alicia1529 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
Alicia1529 commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612731574
 
 
   @mxnet-bot run ci [windows-gpu, centos-gpu, unix-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614689514
 
 
   Jenkins CI successfully triggered : [windows-cpu, windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
haojin2 commented on a change in pull request #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#discussion_r404528475
 
 

 ##########
 File path: python/mxnet/symbol/numpy/_symbol.py
 ##########
 @@ -6799,6 +6799,56 @@ def bincount(x, weights=None, minlength=0):
     return _npi.bincount(x, weights=weights, minlength=minlength, has_weights=True)
 
 
+@set_module('mxnet.symbol.numpy')
+def unpackbits(a, axis=None, count=None, bitorder='big'):
+    """
+    unpackbits(a, axis=None, count=None, bitorder='big')
+
+    Unpacks elements of a uint8 array into a binary-valued output array.
+
+    Each element of `a` represents a bit-field that should be unpacked
+    into a binary-valued output array. The shape of the output array is
+    either 1-D (if `axis` is ``None``) or the same shape as the input
+    array with unpacking done along the axis specified.
+
+    Parameters
+    ----------
+    a : ndarray, uint8 type
 
 Review comment:
   `a : _Symbol`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-612571269
 
 
   Jenkins CI successfully triggered : [unix-cpu, centos-cpu, windows-gpu, centos-gpu, unix-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17905: [Numpy] add op unpackbits
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-614450607
 
 
   Jenkins CI successfully triggered : [windows-cpu, windows-gpu]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] haojin2 commented on issue #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #17905:
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-617552327


   @mxnet-bot run ci [unix-gpu, sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] haojin2 commented on pull request #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
haojin2 commented on pull request #17905:
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-618641507


   @mxnet-bot run ci [all]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #17905: [Numpy] add op unpackbits

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #17905:
URL: https://github.com/apache/incubator-mxnet/pull/17905#issuecomment-618641671


   Jenkins CI successfully triggered : [unix-gpu, edge, windows-gpu, unix-cpu, website, centos-cpu, miscellaneous, windows-cpu, sanity, clang, centos-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org