Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

["Daniel Richard G." <sk...@iSKUNK.ORG>]

The apr-util package accepts an option --with-expat, described in the
configure script help output as

    --with-expat=DIR        specify Expat location, or 'builtin'

I want to use 'builtin'. Knowing that the options I give to Subversion's
top-level configure script are passed down to the sub-projects, I
specify --with-expat=builtin to the top-level script.

Uh oh, I get this:

    checking for Expat... no
    configure: error: Invalid syntax of argument of --with-expat option

The top-level script also takes a --with-expat option, but it is
described a little differently:

    --with-expat=INCLUDES:LIB_SEARCH_DIRS:LIBS
                            Specify location of Expat

The three-part argument syntax is enforced by the script, which is why
the 'builtin' argument didn't work.

I've attached a proposed patch against SVN that allows the top-level
script to accept the 'builtin' value, and otherwise behave as though the
--with-expat option had not been specified at all.

This is only a partial workaround, however, because if I wanted to
specify an external Expat location to apr-util, there would still be no
way to do so. Either the syntax of these two options needs to be
harmonized, or Subversion should rename its option to something not
already used by a sub-project.


--Daniel

(Please Cc: me on any replies, as I am not subscribed to this list.)


-- 
Daniel Richard G. || skunk@iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.

Re: Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

[Stefan Sperling <st...@elego.de>]

On Wed, Jun 20, 2012 at 12:30:16PM -0400, Daniel Richard G. wrote:
> This isn't meant to raise an error at all; the aim is to fool the
> top-level script into thinking the user didn't specify --with-expat=* in
> this one specific case.

Ah, I see. I misunderstood the code you've written.
Committed, with a more elaborate comment, in r1352231. Thanks!

Re: Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

["Daniel Richard G." <sk...@iSKUNK.ORG>]

Hi Stefan,

On Wed, 2012 Jun 20 12:05+0200, Stefan Sperling wrote:
> >
> > +# apr-util accepts "builtin" as an argument to this option
> > +test "_$svn_lib_expat" = "_builtin" && svn_lib_expat="::expat"
>
> Looks like this will make the script error out without an error
> message. That might confuse people. Can you please add an error
> message?

Do you mean, this causes the script to error out in "set -e" mode? If
that's it, the line could be re-written as

    test "_$svn_lib_expat" != "_builtin" || svn_lib_expat="::expat"

This isn't meant to raise an error at all; the aim is to fool the
top-level script into thinking the user didn't specify --with-expat=* in
this one specific case.


--Daniel


-- 
Daniel Richard G. || skunk@iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.

Re: Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

[Stefan Sperling <st...@elego.de>]

On Tue, Jun 19, 2012 at 02:10:02PM -0400, Daniel Richard G. wrote:
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 1351789)
> +++ configure.ac	(working copy)
> @@ -373,6 +373,9 @@
>                   [svn_lib_expat="$withval"],
>                   [svn_lib_expat="::expat"])
>  
> +# apr-util accepts "builtin" as an argument to this option
> +test "_$svn_lib_expat" = "_builtin" && svn_lib_expat="::expat"
> +

Looks like this will make the script error out without an error message.
That might confuse people. Can you please add an error message?

I'd also prefer your test to happen after this message is printed:
>  AC_MSG_CHECKING([for Expat])

>  if test -n "`echo "$svn_lib_expat" | $EGREP ":.*:"`"; then
>    SVN_XML_INCLUDES=""