You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bval.apache.org by mb...@apache.org on 2018/04/03 21:49:31 UTC
bval git commit: correctly handle IMPLICIT constraintTarget
Repository: bval
Updated Branches:
refs/heads/bv2 283c4e8c3 -> 64aee232f
correctly handle IMPLICIT constraintTarget
Project: http://git-wip-us.apache.org/repos/asf/bval/repo
Commit: http://git-wip-us.apache.org/repos/asf/bval/commit/64aee232
Tree: http://git-wip-us.apache.org/repos/asf/bval/tree/64aee232
Diff: http://git-wip-us.apache.org/repos/asf/bval/diff/64aee232
Branch: refs/heads/bv2
Commit: 64aee232fa9c13bdd6b7ded4b1c47abf2ea83188
Parents: 283c4e8
Author: Matt Benson <mb...@apache.org>
Authored: Tue Apr 3 16:49:25 2018 -0500
Committer: Matt Benson <mb...@apache.org>
Committed: Tue Apr 3 16:49:25 2018 -0500
----------------------------------------------------------------------
.../main/java/org/apache/bval/jsr/descriptor/ConstraintD.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/bval/blob/64aee232/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
----------------------------------------------------------------------
diff --git a/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java b/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
index a8f95ed..494002b 100644
--- a/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
+++ b/bval-jsr/src/main/java/org/apache/bval/jsr/descriptor/ConstraintD.java
@@ -240,7 +240,7 @@ public class ConstraintD<A extends Annotation> implements ConstraintDescriptor<A
private ConstraintTarget computeValidationAppliesTo(ElementType elementType) {
final ConstraintTarget result = read(ConstraintAnnotationAttributes.VALIDATION_APPLIES_TO);
- if (result != null) {
+ if (result != null && result != ConstraintTarget.IMPLICIT) {
final AnnotatedElement host = meta.getHost();
Exceptions.raiseUnless(host instanceof Executable, ConstraintDeclarationException::new, "Illegal %s on %s",
result, host);
@@ -254,9 +254,9 @@ public class ConstraintD<A extends Annotation> implements ConstraintDescriptor<A
Exceptions.raiseIf(Void.TYPE.equals(meta.getType()), ConstraintDeclarationException::new,
"Illegal %s on %s method %s", result, Void.TYPE, host);
break;
- case IMPLICIT:
- // handled in ReflectionBuilder
default:
+ Exceptions.raise(IllegalStateException::new, "Unknown %s %s", ConstraintTarget.class.getSimpleName(),
+ result);
}
}
return result;