[GitHub] [accumulo] ctubbsii commented on a change in pull request #2467: Added mechanism to cancel FaTE operations from Shell with Manager up

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2467:
URL: https://github.com/apache/accumulo/pull/2467#discussion_r800989448



##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java
##########
@@ -136,7 +140,29 @@ public int execute(final String fullCommand, final CommandLine cl, final Shell s
         getZooReaderWriter(context, siteConfig, cl.getOptionValue(secretOption.getOpt()));
     ZooStore<FateCommand> zs = new ZooStore<>(path, zk);
 
-    if ("fail".equals(cmd)) {
+    if ("fail-live".equals(cmd)) {

Review comment:
       To Ed's question, "Does canceling a compaction raise to that level?" ... I think both operations are pretty abnormal... to the point that I'm still wondering whether we really need to be able to do this live when taking the manager offline is probably fine, and safest, under abnormal conditions. I worry that people will normalize it, and their systems will become unstable over time by abusing this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org