You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 21:18:28 UTC
[GitHub] [flink] bowenli86 opened a new pull request #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
bowenli86 opened a new pull request #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846
## What is the purpose of the change
according to FLIP-79, CatalogFunction shouldn't have "isTemporary" property. Moving that from CatalogFunction to Create/AlterCatalogFunctionOperation
## Brief change log
- removed "isTemporary" property from CatalogFunction
- moved "isTemporary" property from CatalogFunction to Create/AlterCatalogFunctionOperation
## Verifying this change
This change is already covered by existing tests, such as *FunctionITCase*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846:
[FLINK-15576][table] remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576][table] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144413069 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:afc7961586a39ae36d98a361357e2f68332d177a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:afc7961586a39ae36d98a361357e2f68332d177a
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
* ce759752d6f366efb088c0910b77e1f7d5c95266 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144413069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344)
* afc7961586a39ae36d98a361357e2f68332d177a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10846:
[FLINK-15576] remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#discussion_r366139545
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogFunctionOperation.java
##########
@@ -34,14 +34,18 @@
private final ObjectIdentifier functionIdentifier;
private CatalogFunction catalogFunction;
private boolean ignoreIfExists;
+ private boolean isTemporary;
public CreateCatalogFunctionOperation(
ObjectIdentifier functionIdentifier,
CatalogFunction catalogFunction,
- boolean ignoreIfExists) {
+ boolean ignoreIfExists,
+ boolean isTemporary) {
this.functionIdentifier = functionIdentifier;
this.catalogFunction = catalogFunction;
this.ignoreIfExists = ignoreIfExists;
+ this.isTemporary = isTemporary;
+
Review comment:
remove empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846:
[FLINK-15576][table] remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576][table] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144413069 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
* ce759752d6f366efb088c0910b77e1f7d5c95266 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144413069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
* ce759752d6f366efb088c0910b77e1f7d5c95266 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846:
[FLINK-15576][table] remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576][table] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144413069 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:afc7961586a39ae36d98a361357e2f68332d177a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144422252 TriggerType:PUSH TriggerID:afc7961586a39ae36d98a361357e2f68332d177a
Hash:afc7961586a39ae36d98a361357e2f68332d177a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4346 TriggerType:PUSH TriggerID:afc7961586a39ae36d98a361357e2f68332d177a
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
* ce759752d6f366efb088c0910b77e1f7d5c95266 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144413069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344)
* afc7961586a39ae36d98a361357e2f68332d177a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144422252) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4346)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10846: [FLINK-15576] remove
isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573876423
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b0d258309df96a7a554c209447d67fd814404f70 (Mon Jan 13 21:20:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846:
[FLINK-15576][table] remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576][table] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144384102 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:883e8212106db780488a95a189f315d5faeb06af Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340 TriggerType:PUSH TriggerID:883e8212106db780488a95a189f315d5faeb06af
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144395183 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:8cf7f821a7d08a7200c8f561446681bd992951cc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342 TriggerType:PUSH TriggerID:8cf7f821a7d08a7200c8f561446681bd992951cc
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144413069 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:ce759752d6f366efb088c0910b77e1f7d5c95266 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344 TriggerType:PUSH TriggerID:ce759752d6f366efb088c0910b77e1f7d5c95266
Hash:afc7961586a39ae36d98a361357e2f68332d177a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144422252 TriggerType:PUSH TriggerID:afc7961586a39ae36d98a361357e2f68332d177a
Hash:afc7961586a39ae36d98a361357e2f68332d177a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4346 TriggerType:PUSH TriggerID:afc7961586a39ae36d98a361357e2f68332d177a
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
* 883e8212106db780488a95a189f315d5faeb06af Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144384102) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4340)
* 8cf7f821a7d08a7200c8f561446681bd992951cc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144395183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4342)
* ce759752d6f366efb088c0910b77e1f7d5c95266 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144413069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4344)
* afc7961586a39ae36d98a361357e2f68332d177a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144422252) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4346)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10846: [FLINK-15576]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144229106 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306 TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144229106) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4306)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10846: [FLINK-15576][table]
remove isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10846: [FLINK-15576][table] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10846: [FLINK-15576] remove
isTemporary property from CatalogFunction API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#issuecomment-573891234
<!--
Meta data
Hash:80e2955738437b0dd0b6004fac252f383fb6b426 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:80e2955738437b0dd0b6004fac252f383fb6b426
-->
## CI report:
* 80e2955738437b0dd0b6004fac252f383fb6b426 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services