You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/21 16:06:24 UTC

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #497: feat: add Service and Upstream refactoring

nic-chen commented on a change in pull request #497:
URL: https://github.com/apache/apisix-dashboard/pull/497#discussion_r492178489



##########
File path: api/route/base.go
##########
@@ -44,16 +46,18 @@ func SetUpRouter() *gin.Engine {
 	AppendHealthCheck(r)
 	AppendAuthentication(r)
 	//AppendRoute(r)
-	AppendSsl(r)
+	//AppendSsl(r)
 	AppendPlugin(r)
-	AppendUpstream(r)
+	//AppendUpstream(r)

Review comment:
       we need them to debug or compare.will remove them once when complete the refactoring work. 
    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org