You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:48:46 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28615: [SPARK-31778][K8S][BUILD] Support cross-building docker images

dongjoon-hyun commented on a change in pull request #28615:
URL: https://github.com/apache/spark/pull/28615#discussion_r429378557



##########
File path: bin/docker-image-tool.sh
##########
@@ -212,23 +230,24 @@ Builds or pushes the built-in Spark Docker image.
 
 Commands:
   build       Build image. Requires a repository address to be provided if the image will be
-              pushed to a different registry.
+	      pushed to a different registry.
   push        Push a pre-built image to a registry. Requires a repository address to be provided.
 
 Options:
   -f file               Dockerfile to build for JVM based Jobs. By default builds the Dockerfile shipped with Spark.
   -p file               (Optional) Dockerfile to build for PySpark Jobs. Builds Python dependencies and ships with Spark.
-                        Skips building PySpark docker image if not specified.
+			Skips building PySpark docker image if not specified.

Review comment:
       Please remove `TAB` here~ :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org