You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 14:23:14 UTC
[GitHub] [airflow] potiuk opened a new pull request #13540: Add python-daemon limit for python 3.8+
potiuk opened a new pull request #13540:
URL: https://github.com/apache/airflow/pull/13540
Related to #11456. Python daemon crashes with 'socket operation on
non-socket' for versions < 2.2.4.
The issue is https://pagure.io/python-daemon/issue/34
The fix is: https://pagure.io/python-daemon/c/b708912
And it's been released in 2.2.4 version:
https://pagure.io/python-daemon/blob/55ea71020486ea299ecbc03aec8e7f9dca2f5a85/f/ChangeLog
This PR adds limitation for python 3.8 to require
python-daemon at least 2.2.4.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13540: Add python-daemon limit for python 3.8+
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13540:
URL: https://github.com/apache/airflow/pull/13540#issuecomment-756187005
Yes I get that, but I think this makes maintenance harder for us -- it's more cognitive load when looking at this, so as long as the version works on all our python versions (looks like it does) I'd say we just update it for all python versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13540: Add python-daemon limit for python 3.8+
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13540:
URL: https://github.com/apache/airflow/pull/13540#issuecomment-756170713
It's in the issue title https://pagure.io/python-daemon/issue/34:
`Test errors on Python **3.8**: OSError: [Errno 88] Socket operation on non-socket`
Closed: Fixed 2 years ago by bignose. Opened 2 years ago by churchyard.
I prefer to only limit if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13540: Add python-daemon limit for python 3.8+
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13540:
URL: https://github.com/apache/airflow/pull/13540#issuecomment-756272207
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13540: Add python-daemon limit for python 3.8+
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13540:
URL: https://github.com/apache/airflow/pull/13540#issuecomment-756197611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13540: Add python-daemon limit for python 3.8+
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13540:
URL: https://github.com/apache/airflow/pull/13540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org