You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Jiri Daněk (JIRA)" <ji...@apache.org> on 2018/09/10 08:19:00 UTC
[jira] [Commented] (ARTEMIS-2016) Wait.waitFor is sometimes called
with zero timeout (durationMillis), or with durationMillis < sleepMillis
[ https://issues.apache.org/jira/browse/ARTEMIS-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608855#comment-16608855 ]
Jiri Daněk commented on ARTEMIS-2016:
-------------------------------------
I thought about this again and I now think the zero timeout is perfectly ok value (since the test works with it just fine, so why make it longer, right). Thanks.
> Wait.waitFor is sometimes called with zero timeout (durationMillis), or with durationMillis < sleepMillis
> ---------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2016
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2016
> Project: ActiveMQ Artemis
> Issue Type: Test
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Fix For: 2.6.3
>
>
> {{timeout = 0}} happens in {{org.apache.activemq.artemis.tests.integration.clientcrash.ClientTestBase#assertActiveConnections(int)}} and {{org.apache.activemq.artemis.tests.integration.clientcrash.ClientTestBase#assertActiveSession(int)}}.
> {{durationMillis < sleepMillis}} happens in {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest#assertMetrics}}
> I am not sure what the intent of the author of the test was, but the current state seems wrong. The test {{QueueControlTest#testRemoveAllWithPagingMode}} is flaky due to insufficient number of retry attempts in {{QueueControlTest#assertMetrics}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)