You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/07/27 18:01:00 UTC

[GitHub] [guacamole-client] jmuehlner commented on pull request #746: GUACAMOLE-1320: Provide chunked file upload mechanism

jmuehlner commented on PR #746:
URL: https://github.com/apache/guacamole-client/pull/746#issuecomment-1197111920

   Awesome, the code is all looking pretty good to me. The only remaining thing I have is the commit messages. Both have the same message, which is not going to be very helpful when looking back at the commit history in the future.
   
   I would consider either changing the message of the commits so that each summarizes the changes in that particular commit, or you could squash/rebase them both into a single commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org