You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 23:38:36 UTC
[GitHub] [airflow] kubatyszko opened a new pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
kubatyszko opened a new pull request #13355:
URL: https://github.com/apache/airflow/pull/13355
… Secrets Manager and likely other secrets backends
In some cases, URI's you will need stored in Secrets Manager may not be intuitive, for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this:
http://https%3A%2F%2Fexample.com
spark://spark%3A%2F%2Fspark-master-0.spark-master.spark.svc.cluster.local:7077
This is a known situation, where schema and protocol parts of the URI are indepentent and in some cases, need to be specified explicitely.
See https://github.com/apache/airflow/pull/10256 and https://github.com/apache/airflow/issues/10913 for more detailed discussion that led to this documentation update. This may get resolved in the future.
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-752717526
Spelling problem :(. Add the:
```
..spelling:
Fspark
```
I guess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-753424513
> Yep. I understand. But the spell-checker does not and thinks it is a misspelled word. By adding ..spelling: directive you let the spellchecker know that this is not a typo :)
If it were marked as a code snippet or as a block literal, it would not be spell check. I'll correct it in a moment to make it look better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kubatyszko commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
kubatyszko commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-753163991
Thanks. Happy New Year @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-752950398
> That is correct and intentional, in both URI's, the %3A%2F%2F portion resolves to ://
Yep. I understand. But the spell-checker does not and thinks it is a misspelled word. By adding ..spelling: directive you let the spellchecker know that this is not a typo :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-751920155
[The Workflow run](https://github.com/apache/airflow/actions/runs/449860573) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kubatyszko commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
kubatyszko commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-752729403
> Spelling problem :(. Add the:
>
> ```
> ..spelling:
>
> Fspark
> ```
>
> I guess
That is correct and intentional, in both URI's, the %3A%2F%2F portion resolves to ://
The last F is what you thought belongs to "spark" yielding "Fspark" while it belongs to the %2F representing slash (/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13355:
URL: https://github.com/apache/airflow/pull/13355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kubatyszko closed pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
kubatyszko closed pull request #13355:
URL: https://github.com/apache/airflow/pull/13355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-753098274
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-753098806
Happy New Year @kubatyszko !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kubatyszko commented on pull request #13355: Adding documentation explaining "strange" URI required when using AWS…
Posted by GitBox <gi...@apache.org>.
kubatyszko commented on pull request #13355:
URL: https://github.com/apache/airflow/pull/13355#issuecomment-753087250
@potiuk the checks finally passed :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org