You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "junrushao (via GitHub)" <gi...@apache.org> on 2023/03/06 21:02:44 UTC
[GitHub] [tvm] junrushao opened a new pull request, #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
junrushao opened a new pull request, #14217:
URL: https://github.com/apache/tvm/pull/14217
This PR introduces a syntactic sugar that combines T.env_thread and T.launch_thread.
Previously, an AttrStmt that specifies thread extent or virtual thread is required to be written in two steps:
```python
bx = T.env_thread("blockIdx.x") // creates an IterVar
with T.launch_thread(bx, 128): // specify the iter domain
...
```
With this PR, now this behavior can be merged in a single line:
```python
with T.launch_thread("blockIdx.x", 128) as bx:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1457363804
@Hzfengsy Existing roundtripping tests should suffice already. Do you prefer if I added a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1456993880
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1457417852
Got it. @Hzfengsy Just added a new testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1457367577
> @Hzfengsy Existing roundtripping tests should suffice already. Do you prefer if I added a new one?
It would be great if we can have another explicit one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1456994652
CC: @spectrometerHBH @yzh119 @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #14217:
URL: https://github.com/apache/tvm/pull/14217#issuecomment-1457362984
Could you please add a test case for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #14217: [TVMScript] Sugar T.env_thread + T.launch_thread
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #14217:
URL: https://github.com/apache/tvm/pull/14217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org