You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Hari Shreedharan (JIRA)" <ji...@apache.org> on 2012/09/10 08:26:07 UTC
[jira] [Created] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Hari Shreedharan created AVRO-1151:
--------------------------------------
Summary: Netty Avro server should expose the number of connections currently open.
Key: AVRO-1151
URL: https://issues.apache.org/jira/browse/AVRO-1151
Project: Avro
Issue Type: Improvement
Components: java
Reporter: Hari Shreedharan
It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated AVRO-1151:
-----------------------------------
Priority: Minor (was: Major)
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated AVRO-1151:
-----------------------------------
Status: Patch Available (was: Open)
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated AVRO-1151:
----------------------------
Resolution: Fixed
Fix Version/s: 1.7.2
Assignee: Hari Shreedharan
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Hari!
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Fix For: 1.7.2
>
> Attachments: AVRO-1151-2.patch, AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451984#comment-13451984 ]
Tom White commented on AVRO-1151:
---------------------------------
+1
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151-2.patch, AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451959#comment-13451959 ]
Hari Shreedharan commented on AVRO-1151:
----------------------------------------
Thanks Tom. I will post an updated patch with these changes. In case of the second comment, the channel is being removed from all channels in exceptionCaught() in this patch itself.
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated AVRO-1151:
-----------------------------------
Attachment: AVRO-1151.patch
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451936#comment-13451936 ]
Tom White commented on AVRO-1151:
---------------------------------
A few comments on the patch:
* Why close the channel and remove from allChannels in the channelDisconnected() method? Does it not suffice to just have the channelClosed() method?
* The channel should also be removed from allChannels in exceptionCaught().
* There are some whitespace-only changes in the patch which should be removed.
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan updated AVRO-1151:
-----------------------------------
Attachment: AVRO-1151-2.patch
Updated patch incorporating Tom's feedback.
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151-2.patch, AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1151) Netty Avro server should expose the
number of connections currently open.
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451795#comment-13451795 ]
Hari Shreedharan commented on AVRO-1151:
----------------------------------------
Initial patch, which removes the channel from the set when the channel is closed or disconnected. Also exposes the number of open connections.
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
> Key: AVRO-1151
> URL: https://issues.apache.org/jira/browse/AVRO-1151
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Hari Shreedharan
> Priority: Minor
> Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer for metrics for applications using the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira