You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:10:33 UTC

[GitHub] [iceberg] pvary edited a comment on pull request #1612: Hive: Using Hive schema to create tables and partition specification

pvary edited a comment on pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#issuecomment-720653349


   > I'm not quite convinced that not supporting the Hive `PARTITIONED BY` clause is the right way to go, but I think it is a reasonable step to get this patch done. We don't need to support it to support the Schema DDL, so it would be fine with me to throw an exception and reject its use for now.
   
   Updated the patch to throw an exception if `PARTITIONED BY` is used.
    
   > What are the chances of integrating Iceberg into Hive itself and solving some of these limitations?
   
   If we want to change the Hive syntax we would need Hive to depend on Iceberg.
   
   Iceberg has 2 dependencies on Hive
   - HMS API to store the snapshot
   - SerDe implementation
   
   That would mean that we have cyclic dependency which could be problematic
   (Edit) Maybe moving the SerDe implementation to the Hive repo could narrow down the Iceberg dependency on Hive to avoid serious headaches


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org