You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/08/20 19:03:12 UTC
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 10:03 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Bugs: MESOS-3299
https://issues.apache.org/jira/browse/MESOS-3299
Repository: mesos
Description (updated)
-------
Instead of using doubles, seconds and nanoseconds can be represented like
`struct timespec`, with one field for seconds and one for nanoseconds.
This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
Note about the naming:
* Time will conflict with the Time class.
* Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
Diffs
-----
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
Diff: https://reviews.apache.org/r/37655/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96269
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 12:14 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
>
> This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
>
> Note about the naming:
>
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
> include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
>
> Diff: https://reviews.apache.org/r/37655/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96285
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37655]
All tests passed.
- Mesos ReviewBot
On Aug. 25, 2015, 12:14 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
>
> This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
>
> Note about the naming:
>
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
> include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
>
> Diff: https://reviews.apache.org/r/37655/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 5:14 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Update comments. Copy to V1 API too.
Bugs: MESOS-3299
https://issues.apache.org/jira/browse/MESOS-3299
Repository: mesos
Description
-------
Instead of using doubles, seconds and nanoseconds can be represented like
`struct timespec`, with one field for seconds and one for nanoseconds.
This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
Note about the naming:
* Time will conflict with the Time class.
* Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
Diffs (updated)
-----
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
Diff: https://reviews.apache.org/r/37655/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96244
-----------------------------------------------------------
Ship it!
Ship It!
include/mesos/mesos.proto (line 98)
<https://reviews.apache.org/r/37655/#comment151584>
Can you expand the comment to make it clean that nanoseconds is the remainder, not a more precise representation of the full amount of time.
- Joris Van Remoortere
On Aug. 20, 2015, 5:03 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 5:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
>
> This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
>
> Note about the naming:
>
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
>
> Diff: https://reviews.apache.org/r/37655/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37655: MESOS-3299: Add protobuf to represent time
with integer precision.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review95981
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37655]
All tests passed.
- Mesos ReviewBot
On Aug. 20, 2015, 5:03 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 5:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3299
> https://issues.apache.org/jira/browse/MESOS-3299
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
>
> This will be important if frameworks need to compare times to make decisions (such as for maintenance primitives).
>
> Note about the naming:
>
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
>
> Diff: https://reviews.apache.org/r/37655/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>