You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by abhinandanprateek <gi...@git.apache.org> on 2016/11/16 10:22:20 UTC
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1765
Cloudstack 9586: When using local storage with Xenserver prepareTemplate does not work with multiple primary store
The race condition will happen whenever there are multiple primary storages and the CS tries to mount the secondary store to xenserver host simultaneously.
Due to synchronised block one mount will be successful and other thread will get the already mounted SR. Without the fix the two thread will try to mount it parallely and one will fail on Xenserver.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1765
----
commit 615e87496c3f80964cc09faf9e8085eb25f1aaf0
Author: Abhinandan Prateek <ap...@apache.org>
Date: 2016-11-16T10:15:19Z
CLOUDSTACK-9586: If there are multiple primary storages in use, then the race condition to create SR is fixed by this patch
commit 42cd40976240135e2d9001cb293b44d522ddfe3e
Author: Abhinandan Prateek <ap...@apache.org>
Date: 2016-11-16T10:17:24Z
CLOUDSTACK-9586: marvin test to run prepare template that will copy the template to multiple primaries in parallel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Packaging result: \u2714centos6 \u2714centos7 \u2716debian. JID-312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
<b>Trillian test result (tid-439)</b>
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32353 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1765-t439-xenserver-65sp1.zip
Test completed. 40 look ok, 3 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 479.43 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1393.38 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 542.29 | test_vpc_redundant.py
test_router_dhcp_opts | `Failure` | 21.05 | test_router_dhcphosts.py
test_01_vpc_site2site_vpn | `Error` | 853.81 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 157.83 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 513.82 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 292.03 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 679.38 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 874.21 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1041.31 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 21.22 | test_volumes.py
test_08_resize_volume | Success | 111.19 | test_volumes.py
test_07_resize_fail | Success | 116.37 | test_volumes.py
test_06_download_detached_volume | Success | 20.57 | test_volumes.py
test_05_detach_volume | Success | 100.31 | test_volumes.py
test_04_delete_attached_volume | Success | 10.48 | test_volumes.py
test_03_download_attached_volume | Success | 20.34 | test_volumes.py
test_02_attach_volume | Success | 16.37 | test_volumes.py
test_01_create_volume | Success | 392.87 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.37 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 186.81 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 133.82 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 300.01 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.15 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.40 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.94 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.27 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 15.26 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.36 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.41 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.58 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 171.56 | test_templates.py
test_08_list_system_templates | Success | 0.06 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.09 | test_templates.py
test_04_extract_template | Success | 5.19 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.10 | test_templates.py
test_01_create_template | Success | 76.21 | test_templates.py
test_10_destroy_cpvm | Success | 226.87 | test_ssvm.py
test_09_destroy_ssvm | Success | 204.65 | test_ssvm.py
test_08_reboot_cpvm | Success | 111.64 | test_ssvm.py
test_07_reboot_ssvm | Success | 154.00 | test_ssvm.py
test_06_stop_cpvm | Success | 136.91 | test_ssvm.py
test_05_stop_ssvm | Success | 173.98 | test_ssvm.py
test_04_cpvm_internals | Success | 1.40 | test_ssvm.py
test_03_ssvm_internals | Success | 3.94 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.18 | test_ssvm.py
test_01_snapshot_root_disk | Success | 31.52 | test_snapshots.py
test_04_change_offering_small | Success | 91.84 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.09 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.16 | test_service_offerings.py
test_01_create_service_offering | Success | 0.28 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_01_scale_vm | Success | 5.21 | test_scale_vm.py
test_09_reboot_router | Success | 60.52 | test_routers.py
test_08_start_router | Success | 45.40 | test_routers.py
test_07_stop_router | Success | 15.21 | test_routers.py
test_06_router_advanced | Success | 0.07 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.52 | test_routers.py
test_03_restart_network_cleanup | Success | 105.95 | test_routers.py
test_02_router_internal_adv | Success | 0.81 | test_routers.py
test_01_router_internal_basic | Success | 0.42 | test_routers.py
test_router_dhcphosts | Success | 123.37 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.28 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 101.14 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.46 | test_pvlan.py
test_dedicatePublicIpRange | Success | 1.34 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 1009.07 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 816.39 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 600.84 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 195.22 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 39.32 | test_primary_storage.py
test_01_primary_storage_iscsi | Success | 78.70 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.56 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 20.70 | test_portable_publicip.py
test_isolate_network_password_server | Success | 62.82 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.14 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.37 | test_non_contigiousvlan.py
test_01_nic | Success | 845.36 | test_nic.py
test_releaseIP | Success | 314.93 | test_network.py
test_reboot_router | Success | 475.96 | test_network.py
test_public_ip_user_account | Success | 10.33 | test_network.py
test_public_ip_admin_account | Success | 40.27 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 77.24 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.74 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 92.77 | test_network.py
test_delete_account | Success | 229.10 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.77 | test_network.py
test_01_port_fwd_on_src_nat | Success | 78.80 | test_network.py
test_nic_secondaryip_add_remove | Success | 158.81 | test_multipleips_per_nic.py
login_test_saml_user | Success | 26.93 | test_login.py
test_assign_and_removal_lb | Success | 149.24 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 202.57 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 198.62 | test_loadbalance.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.11 | test_iso.py
test_03_delete_iso | Success | 95.20 | test_iso.py
test_02_edit_iso | Success | 0.05 | test_iso.py
test_01_create_iso | Success | 22.30 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 507.30 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 360.99 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 932.43 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 716.12 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.33 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.08 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 96.37 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 41.06 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 227.12 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 15.43 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 116.28 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.79 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 7.42 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 7.29 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 193.65 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 137.03 | test_affinity_groups.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@abhinandanprateek could you please rebase this PR to pick up the fixes to the broken tests? I want to make sure that this PR doesn't introduce any side-effects that break the test runs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@jburwell rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
LGTM.
@abhinandanprateek @murali-reddy @jburwell are we lgtm on this PR?
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
LGTM, last test run looks okay. Failed tests around vpc/rvr are known intermittent issues.
@abhinandanprateek can you squash your commits, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r88393320
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
+ synchronized (srname.intern()) {
+ final Set<SR> srs = SR.getByNameLabel(conn, srname);
+ if (srs != null && !srs.isEmpty()) {
+ return srs.iterator().next();
+ }
+ final Map<String, String> smConfig = new HashMap<String, String>();
+ final Host host = Host.getByUuid(conn, hypervisorResource.getHost().getUuid());
+ final String uuid = UUID.randomUUID().toString();
+ sr = SR.introduce(conn, uuid, srname, srname, "file", "file", false, smConfig);
+ final PBD.Record record = new PBD.Record();
+ record.host = host;
+ record.SR = sr;
+ smConfig.put("location", path);
+ record.deviceConfig = smConfig;
+ pbd = PBD.create(conn, record);
+ pbd.plug(conn);
+ sr.scan(conn);
--- End diff --
The block as a whole needs synchronization as at the start presence of a SR is checked and the last call in the block creates one on the xen pool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
<b>Trillian test result (tid-416)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27983 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1765-t416-kvm-centos7.zip
Test completed. 43 look ok, 0 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | Success | 181.02 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.73 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 292.87 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 294.24 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 630.44 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 627.11 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1383.14 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 717.08 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 785.37 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1493.46 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.59 | test_volumes.py
test_08_resize_volume | Success | 15.47 | test_volumes.py
test_07_resize_fail | Success | 20.70 | test_volumes.py
test_06_download_detached_volume | Success | 15.63 | test_volumes.py
test_05_detach_volume | Success | 100.26 | test_volumes.py
test_04_delete_attached_volume | Success | 10.28 | test_volumes.py
test_03_download_attached_volume | Success | 15.61 | test_volumes.py
test_02_attach_volume | Success | 74.42 | test_volumes.py
test_01_create_volume | Success | 802.17 | test_volumes.py
test_deploy_vm_multiple | Success | 294.37 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.26 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.37 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.32 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.99 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.97 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.22 | test_vm_life_cycle.py
test_01_stop_vm | Success | 45.49 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 81.22 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.34 | test_templates.py
test_03_delete_template | Success | 5.16 | test_templates.py
test_02_edit_template | Success | 90.20 | test_templates.py
test_01_create_template | Success | 86.23 | test_templates.py
test_10_destroy_cpvm | Success | 196.97 | test_ssvm.py
test_09_destroy_ssvm | Success | 199.25 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.95 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.72 | test_ssvm.py
test_06_stop_cpvm | Success | 137.44 | test_ssvm.py
test_05_stop_ssvm | Success | 169.43 | test_ssvm.py
test_04_cpvm_internals | Success | 1.53 | test_ssvm.py
test_03_ssvm_internals | Success | 5.57 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.28 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.22 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.28 | test_snapshots.py
test_04_change_offering_small | Success | 209.91 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.09 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.19 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.27 | test_secondary_storage.py
test_09_reboot_router | Success | 65.55 | test_routers.py
test_08_start_router | Success | 55.56 | test_routers.py
test_07_stop_router | Success | 10.22 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.05 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.84 | test_routers.py
test_03_restart_network_cleanup | Success | 90.94 | test_routers.py
test_02_router_internal_adv | Success | 1.05 | test_routers.py
test_01_router_internal_basic | Success | 0.57 | test_routers.py
test_router_dhcphosts | Success | 285.61 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.12 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 186.59 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.21 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.40 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 645.92 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 615.45 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 437.45 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 119.25 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 36.23 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.54 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 20.63 | test_portable_publicip.py
test_isolate_network_password_server | Success | 123.71 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.17 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.46 | test_non_contigiousvlan.py
test_01_nic | Success | 818.93 | test_nic.py
test_releaseIP | Success | 331.19 | test_network.py
test_reboot_router | Success | 548.34 | test_network.py
test_public_ip_user_account | Success | 10.47 | test_network.py
test_public_ip_admin_account | Success | 40.44 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 67.53 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 62.25 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 155.73 | test_network.py
test_delete_account | Success | 335.71 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.72 | test_network.py
test_01_port_fwd_on_src_nat | Success | 142.39 | test_network.py
test_nic_secondaryip_add_remove | Success | 209.33 | test_multipleips_per_nic.py
login_test_saml_user | Success | 25.59 | test_login.py
test_assign_and_removal_lb | Success | 133.74 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 188.85 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 189.50 | test_loadbalance.py
test_07_list_default_iso | Success | 0.08 | test_iso.py
test_05_iso_permissions | Success | 0.11 | test_iso.py
test_04_extract_Iso | Success | 5.33 | test_iso.py
test_03_delete_iso | Success | 95.20 | test_iso.py
test_02_edit_iso | Success | 0.05 | test_iso.py
test_01_create_iso | Success | 21.87 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 269.78 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 260.40 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 695.18 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 541.20 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.43 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.15 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.06 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.10 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.26 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.63 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 61.23 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 60.73 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.41 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 116.81 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 7.50 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.93 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 228.98 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 233.92 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 71.07 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r88391404
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
+ synchronized (srname.intern()) {
--- End diff --
Should we consider using a `ReentrantLock` instead of `synchronized`? `ReentrantLock.tryLock(long, TimeUnit)` allows the specification of a timeout to acquire the lock. Since a timeout cannot be specified to `synchronized`, multiple threads may deadlock attempting to acquire the lock in the case of a stall. The downside of this approach is that we would need to track locks in a `ConcurrentMap` -- ideally with WeakReferences to allow them to be garbage collected when no threads are operating on them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
<b>Trillian test result (tid-394)</b>
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33593 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1765-t394-xenserver-65sp1.zip
Test completed. 40 look ok, 3 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 521.96 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1363.41 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 536.62 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | `Error` | 395.17 | test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_04_rvpc_privategw_static_routes | `Error` | 1023.84 | test_privategw_acl.py
test_01_vpc_remote_access_vpn | Success | 157.18 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 307.44 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 654.48 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 817.42 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1068.85 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.74 | test_volumes.py
test_08_resize_volume | Success | 91.21 | test_volumes.py
test_07_resize_fail | Success | 96.33 | test_volumes.py
test_06_download_detached_volume | Success | 20.43 | test_volumes.py
test_05_detach_volume | Success | 100.52 | test_volumes.py
test_04_delete_attached_volume | Success | 10.24 | test_volumes.py
test_03_download_attached_volume | Success | 15.35 | test_volumes.py
test_02_attach_volume | Success | 10.74 | test_volumes.py
test_01_create_volume | Success | 392.80 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.28 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 181.41 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 130.98 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 214.65 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.05 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 42.03 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.36 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.17 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.26 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.48 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.41 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 146.37 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.22 | test_templates.py
test_03_delete_template | Success | 5.16 | test_templates.py
test_02_edit_template | Success | 90.15 | test_templates.py
test_01_create_template | Success | 70.85 | test_templates.py
test_10_destroy_cpvm | Success | 232.15 | test_ssvm.py
test_09_destroy_ssvm | Success | 234.54 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.99 | test_ssvm.py
test_07_reboot_ssvm | Success | 154.13 | test_ssvm.py
test_06_stop_cpvm | Success | 166.75 | test_ssvm.py
test_05_stop_ssvm | Success | 174.19 | test_ssvm.py
test_04_cpvm_internals | Success | 1.23 | test_ssvm.py
test_03_ssvm_internals | Success | 4.15 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 26.93 | test_snapshots.py
test_04_change_offering_small | Success | 76.70 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.15 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.19 | test_service_offerings.py
test_01_create_service_offering | Success | 0.16 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_01_scale_vm | Success | 5.31 | test_scale_vm.py
test_09_reboot_router | Success | 65.61 | test_routers.py
test_08_start_router | Success | 60.66 | test_routers.py
test_07_stop_router | Success | 20.39 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.53 | test_routers.py
test_03_restart_network_cleanup | Success | 136.19 | test_routers.py
test_02_router_internal_adv | Success | 0.67 | test_routers.py
test_01_router_internal_basic | Success | 0.42 | test_routers.py
test_router_dhcphosts | Success | 113.15 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 20.42 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.23 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.49 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 802.13 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 540.57 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 149.09 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 39.79 | test_primary_storage.py
test_01_primary_storage_iscsi | Success | 80.61 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.20 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.75 | test_portable_publicip.py
test_isolate_network_password_server | Success | 61.81 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.81 | test_non_contigiousvlan.py
test_01_nic | Success | 975.51 | test_nic.py
test_releaseIP | Success | 224.40 | test_network.py
test_reboot_router | Success | 511.26 | test_network.py
test_public_ip_user_account | Success | 10.38 | test_network.py
test_public_ip_admin_account | Success | 40.31 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.82 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.76 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 92.62 | test_network.py
test_delete_account | Success | 309.45 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 56.10 | test_network.py
test_01_port_fwd_on_src_nat | Success | 78.99 | test_network.py
test_nic_secondaryip_add_remove | Success | 245.12 | test_multipleips_per_nic.py
login_test_saml_user | Success | 27.90 | test_login.py
test_assign_and_removal_lb | Success | 150.16 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 202.86 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 210.12 | test_loadbalance.py
test_07_list_default_iso | Success | 0.08 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.25 | test_iso.py
test_03_delete_iso | Success | 95.24 | test_iso.py
test_02_edit_iso | Success | 0.07 | test_iso.py
test_01_create_iso | Success | 22.21 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 480.87 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 351.40 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 947.16 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 711.19 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.31 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.23 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.08 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 31.30 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 106.67 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 181.83 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 25.84 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 121.41 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.78 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 7.63 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 6.87 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 228.88 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 408.97 | test_affinity_groups.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r89576730
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
--- End diff --
@abhinandanprateek could there be a case that after upgrade SR.getByNameLabel will fail as the srname has changed? I would say let's not break the naming convention if it's used in/by external resources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r89574062
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
--- End diff --
@rhtyd, since sr is unique on a pool, adding hostname to its path does not give any advantage. Usually MS will go thru the pool master so effectively it will end up the pool master uuid to sr name.
This could have avoided the race condition by probably introducing redundant SRs, but now that the race condition is dealt with we really donot need the host uuid qualification of SR name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r90594670
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
--- End diff --
The SR for a template that is to be copied to primary is temporarily mounted on Xen, after the copy is complete, it is unmounted and SR forgotten on Xen. The SR is temporary and for the current operation only. Having said that it does not really make a difference. @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r90590680
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
--- End diff --
@abhinandanprateek ping, do you think changing the SR name can cause upgrade issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd I have reverted to the sr name as it was.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@abhinandanprateek could you please squash the commits for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
LGTM, tests confirm no regressions. Test LGTM.
Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
<b>Trillian test result (tid-551)</b>
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33164 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1765-t551-xenserver-65sp1.zip
Test completed. 42 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 530.24 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1388.25 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 502.31 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 315.64 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 151.29 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 516.78 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 304.55 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 706.56 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 959.58 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1034.91 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.73 | test_volumes.py
test_08_resize_volume | Success | 105.91 | test_volumes.py
test_07_resize_fail | Success | 116.02 | test_volumes.py
test_06_download_detached_volume | Success | 30.33 | test_volumes.py
test_05_detach_volume | Success | 100.24 | test_volumes.py
test_04_delete_attached_volume | Success | 10.13 | test_volumes.py
test_03_download_attached_volume | Success | 20.70 | test_volumes.py
test_02_attach_volume | Success | 10.74 | test_volumes.py
test_01_create_volume | Success | 392.57 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.12 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 181.29 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 132.59 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 187.47 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 81.91 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 60.95 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 15.15 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.19 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.21 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.22 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 191.32 | test_templates.py
test_08_list_system_templates | Success | 0.07 | test_templates.py
test_07_list_public_templates | Success | 0.09 | test_templates.py
test_05_template_permissions | Success | 0.12 | test_templates.py
test_04_extract_template | Success | 5.23 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 65.46 | test_templates.py
test_10_destroy_cpvm | Success | 226.58 | test_ssvm.py
test_09_destroy_ssvm | Success | 198.77 | test_ssvm.py
test_08_reboot_cpvm | Success | 151.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 144.10 | test_ssvm.py
test_06_stop_cpvm | Success | 196.59 | test_ssvm.py
test_05_stop_ssvm | Success | 138.94 | test_ssvm.py
test_04_cpvm_internals | Success | 1.13 | test_ssvm.py
test_03_ssvm_internals | Success | 3.59 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.10 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.14 | test_snapshots.py
test_04_change_offering_small | Success | 68.97 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.06 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_01_scale_vm | Success | 5.25 | test_scale_vm.py
test_09_reboot_router | Success | 65.52 | test_routers.py
test_08_start_router | Success | 60.74 | test_routers.py
test_07_stop_router | Success | 15.22 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.51 | test_routers.py
test_03_restart_network_cleanup | Success | 120.84 | test_routers.py
test_02_router_internal_adv | Success | 0.78 | test_routers.py
test_01_router_internal_basic | Success | 0.40 | test_routers.py
test_router_dhcphosts | Success | 102.37 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.87 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 30.45 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.14 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.28 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 939.55 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 919.59 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 758.13 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 123.17 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 39.10 | test_primary_storage.py
test_01_primary_storage_iscsi | Success | 78.45 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.29 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.60 | test_portable_publicip.py
test_isolate_network_password_server | Success | 61.58 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.34 | test_non_contigiousvlan.py
test_01_nic | Success | 796.86 | test_nic.py
test_releaseIP | Success | 353.79 | test_network.py
test_reboot_router | Success | 646.98 | test_network.py
test_public_ip_user_account | Success | 10.21 | test_network.py
test_public_ip_admin_account | Success | 40.34 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.53 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.34 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 92.01 | test_network.py
test_delete_account | Success | 242.67 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.56 | test_network.py
test_01_port_fwd_on_src_nat | Success | 79.08 | test_network.py
test_nic_secondaryip_add_remove | Success | 253.87 | test_multipleips_per_nic.py
login_test_saml_user | Success | 23.10 | test_login.py
test_assign_and_removal_lb | Success | 144.31 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 207.54 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 209.58 | test_loadbalance.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.04 | test_iso.py
test_04_extract_Iso | Success | 5.15 | test_iso.py
test_03_delete_iso | Success | 95.20 | test_iso.py
test_02_edit_iso | Success | 0.04 | test_iso.py
test_01_create_iso | Success | 21.93 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 546.57 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 334.14 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1039.53 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 722.99 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 5.33 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.26 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.06 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 40.69 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 212.09 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 241.92 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 25.52 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 151.50 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.35 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.16 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 7.38 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 202.77 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 272.51 | test_affinity_groups.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r88391467
--- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() + path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
+ synchronized (srname.intern()) {
+ final Set<SR> srs = SR.getByNameLabel(conn, srname);
+ if (srs != null && !srs.isEmpty()) {
+ return srs.iterator().next();
+ }
+ final Map<String, String> smConfig = new HashMap<String, String>();
+ final Host host = Host.getByUuid(conn, hypervisorResource.getHost().getUuid());
+ final String uuid = UUID.randomUUID().toString();
+ sr = SR.introduce(conn, uuid, srname, srname, "file", "file", false, smConfig);
+ final PBD.Record record = new PBD.Record();
+ record.host = host;
+ record.SR = sr;
+ smConfig.put("location", path);
+ record.deviceConfig = smConfig;
+ pbd = PBD.create(conn, record);
+ pbd.plug(conn);
+ sr.scan(conn);
--- End diff --
Some of the work in this `synchronized` block does not appear to need a lock to be successful. Please consider refactoring to move that work out of this block to reduce the size of the critical section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
<b>Trillian test result (tid-417)</b>
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36680 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1765-t417-xenserver-65sp1.zip
Test completed. 41 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 538.68 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1362.57 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 652.15 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | `Error` | 868.35 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 157.37 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 545.95 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 339.55 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 748.96 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 879.79 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1094.51 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 16.02 | test_volumes.py
test_08_resize_volume | Success | 91.26 | test_volumes.py
test_07_resize_fail | Success | 101.21 | test_volumes.py
test_06_download_detached_volume | Success | 20.46 | test_volumes.py
test_05_detach_volume | Success | 100.37 | test_volumes.py
test_04_delete_attached_volume | Success | 10.26 | test_volumes.py
test_03_download_attached_volume | Success | 15.56 | test_volumes.py
test_02_attach_volume | Success | 11.10 | test_volumes.py
test_01_create_volume | Success | 403.81 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.19 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 182.93 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 105.79 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 300.00 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 62.34 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 243.35 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.20 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.47 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.39 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.36 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 238.18 | test_templates.py
test_08_list_system_templates | Success | 0.05 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.08 | test_templates.py
test_04_extract_template | Success | 5.51 | test_templates.py
test_03_delete_template | Success | 5.14 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 96.09 | test_templates.py
test_10_destroy_cpvm | Success | 201.84 | test_ssvm.py
test_09_destroy_ssvm | Success | 259.79 | test_ssvm.py
test_08_reboot_cpvm | Success | 157.02 | test_ssvm.py
test_07_reboot_ssvm | Success | 179.66 | test_ssvm.py
test_06_stop_cpvm | Success | 172.12 | test_ssvm.py
test_05_stop_ssvm | Success | 229.47 | test_ssvm.py
test_04_cpvm_internals | Success | 1.46 | test_ssvm.py
test_03_ssvm_internals | Success | 4.14 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.25 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.25 | test_ssvm.py
test_01_snapshot_root_disk | Success | 31.59 | test_snapshots.py
test_04_change_offering_small | Success | 122.17 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.17 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.29 | test_secondary_storage.py
test_01_scale_vm | Success | 5.51 | test_scale_vm.py
test_09_reboot_router | Success | 80.78 | test_routers.py
test_08_start_router | Success | 55.59 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.52 | test_routers.py
test_03_restart_network_cleanup | Success | 182.31 | test_routers.py
test_02_router_internal_adv | Success | 0.89 | test_routers.py
test_01_router_internal_basic | Success | 0.50 | test_routers.py
test_router_dhcphosts | Success | 114.45 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.32 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 50.72 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.06 | test_regions.py
test_create_pvlan_network | Success | 5.30 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.51 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 1353.14 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1086.20 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 795.34 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 201.94 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 39.97 | test_primary_storage.py
test_01_primary_storage_iscsi | Success | 81.75 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.45 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.80 | test_portable_publicip.py
test_isolate_network_password_server | Success | 36.92 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.15 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.57 | test_non_contigiousvlan.py
test_01_nic | Success | 973.24 | test_nic.py
test_releaseIP | Success | 246.19 | test_network.py
test_reboot_router | Success | 745.04 | test_network.py
test_public_ip_user_account | Success | 10.32 | test_network.py
test_public_ip_admin_account | Success | 40.32 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 77.23 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 66.97 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 97.78 | test_network.py
test_delete_account | Success | 281.02 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 56.01 | test_network.py
test_01_port_fwd_on_src_nat | Success | 114.85 | test_network.py
test_nic_secondaryip_add_remove | Success | 360.82 | test_multipleips_per_nic.py
login_test_saml_user | Success | 26.23 | test_login.py
test_assign_and_removal_lb | Success | 151.34 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 208.21 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 208.83 | test_loadbalance.py
test_07_list_default_iso | Success | 0.09 | test_iso.py
test_05_iso_permissions | Success | 0.15 | test_iso.py
test_04_extract_Iso | Success | 5.20 | test_iso.py
test_03_delete_iso | Success | 95.25 | test_iso.py
test_02_edit_iso | Success | 0.07 | test_iso.py
test_01_create_iso | Success | 21.96 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 516.00 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 355.41 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1048.68 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 766.35 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.63 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.55 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.15 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.09 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.13 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.10 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.12 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 156.97 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 51.21 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 202.54 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.58 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 121.99 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.93 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.80 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 6.94 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 169.91 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 252.88 | test_affinity_groups.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1765
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Test lgtm, based on the test results I'm seeing no new failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@murali-reddy @abhinandanprateek @jburwell pinging for review continuation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---