You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/03/12 01:11:57 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40383: [SPARK-42762][K8S] Improve logging in K8s on disconnect when using StatefulSets

dongjoon-hyun commented on code in PR #40383:
URL: https://github.com/apache/spark/pull/40383#discussion_r1133169570


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -294,10 +295,15 @@ private[spark] class KubernetesClusterSchedulerBackend(
   }
 
   private class KubernetesDriverEndpoint extends DriverEndpoint {
+
+    protected val execIDRequester = new HashMap[RpcAddress, String]
+
     private def generateExecID(context: RpcCallContext): PartialFunction[Any, Unit] = {
       case x: GenerateExecID =>
         val newId = execId.incrementAndGet().toString
         context.reply(newId)
+        val executorAddress = context.senderAddress
+        execIDRequester(executorAddress) = newId

Review Comment:
   Is this used by `StatefulSets` case only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org