[jira] [Commented] (AIRFLOW-6392) Remove cyclic module dependency airfllow.models.baseoperator <-> airflow.utils.helpers

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004782#comment-17004782 ] 

ASF GitHub Bot commented on AIRFLOW-6392:
-----------------------------------------

potiuk commented on pull request #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers
URL: https://github.com/apache/airflow/pull/6950
 
 
   There is a hidden cyclic dependency between baseoperator and helpers module.
   It's hidden by local import but it is detected when baseoperator/helpers are
   removed from pylint_todo.txt (and it's really there).
   
   The dependency comes from BaseOperator using helpers and two helpers methods
   (chain and cross_downstream) using BaseOperator. This can be solved by
   converting the chain and cross_downstream methods to be static methods in
   BaseOperator class.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6392
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove cyclic module dependency airfllow.models.baseoperator <-> airflow.utils.helpers
> --------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6392
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6392
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> There is a hidden cyclic dependency between baseoperator and helpers module. It's hidden by local import but it is detected when baseoperator/helpers are removed from pylint_todo.txt (and it's really there). 
> The dependency comes from BaseOperator using helpers and two helpers methods (chain and cross_downstream) using BaseOperator. This can be solved by converting the chain and cross_downstream methods to be static methods in BaseOperator class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)