You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2009/12/14 19:41:20 UTC

[jira] Created: (AVRO-256) specific: class names can clash in imports

specific: class names can clash in imports
------------------------------------------

                 Key: AVRO-256
                 URL: https://issues.apache.org/jira/browse/AVRO-256
             Project: Avro
          Issue Type: Bug
          Components: java
            Reporter: Doug Cutting
             Fix For: 1.3.0


If a schema references two same-named types in different namespaces, the specific compiler will attempt to import them both, generating illegal Java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AVRO-256) specific: class names can clash in imports

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting resolved AVRO-256.
-------------------------------

    Resolution: Fixed
      Assignee: Doug Cutting

I just committed this.

> specific: class names can clash in imports
> ------------------------------------------
>
>                 Key: AVRO-256
>                 URL: https://issues.apache.org/jira/browse/AVRO-256
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-256.patch
>
>
> If a schema references two same-named types in different namespaces, the specific compiler will attempt to import them both, generating illegal Java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-256) specific: class names can clash in imports

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-256:
------------------------------

    Attachment: AVRO-256.patch

Here's a patch that fixes this.

> specific: class names can clash in imports
> ------------------------------------------
>
>                 Key: AVRO-256
>                 URL: https://issues.apache.org/jira/browse/AVRO-256
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-256.patch
>
>
> If a schema references two same-named types in different namespaces, the specific compiler will attempt to import them both, generating illegal Java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-256) specific: class names can clash in imports

Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790517#action_12790517 ] 

Philip Zeyliger commented on AVRO-256:
--------------------------------------

+1.  Looked at the patch.

We don't yet have any tests that compile the specific code (which is fine; it's irksome to get at the compiler), but I'm satisfied that the regular build compiles at least one of these.

> specific: class names can clash in imports
> ------------------------------------------
>
>                 Key: AVRO-256
>                 URL: https://issues.apache.org/jira/browse/AVRO-256
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-256.patch
>
>
> If a schema references two same-named types in different namespaces, the specific compiler will attempt to import them both, generating illegal Java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-256) specific: class names can clash in imports

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790281#action_12790281 ] 

Doug Cutting commented on AVRO-256:
-----------------------------------

We should change the specific compiler to import nothing and always use fully-qualified class names.

> specific: class names can clash in imports
> ------------------------------------------
>
>                 Key: AVRO-256
>                 URL: https://issues.apache.org/jira/browse/AVRO-256
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>             Fix For: 1.3.0
>
>
> If a schema references two same-named types in different namespaces, the specific compiler will attempt to import them both, generating illegal Java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.