You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by supertinou <gi...@git.apache.org> on 2015/06/22 16:57:24 UTC
[GitHub] couchdb pull request: COUCHDB-2722 Keys from rewrited query params...
GitHub user supertinou opened a pull request:
https://github.com/apache/couchdb/pull/324
COUCHDB-2722 Keys from rewrited query params should be blank when not specified in the URI
## Bug Fix
### COUCHDB-2722
The keys from the rewrited query params of a view should be blank when not specified in the URL.
*Please see the following JIRA link for more details...*
### JIRA
https://issues.apache.org/jira/browse/COUCHDB-2722
### Related Pull Requests
- Fix against __couchdb-couch__ : https://github.com/apache/couchdb-couch/pull/59
- Fix against __couchdb-chttpd__ : https://github.com/apache/couchdb-chttpd/pull/36
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/supertinou/couchdb COUCHDB-2722
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit 44ae25d00ec72a43335812e3193d9dd82178160c
Author: Martin Lagrange <la...@gmail.com>
Date: 2015-06-22T14:52:13Z
COUCHDB-2722
https://issues.apache.org/jira/browse/COUCHDB-2722
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #324: COUCHDB-2722 Keys from rewrited query params should be b...
Posted by benel <gi...@git.apache.org>.
Github user benel commented on the issue:
https://github.com/apache/couchdb/pull/324
@wohali Martin did this for me when he was one of my students. I'm not sure he's still on GitHub.
Which tests do you need to be run? Travis tests?
If yes, here is a rebase on CouchDB master branch: https://github.com/benel/couchdb/tree/COUCHDB-2722
I will open a pull request if it's OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2722 Keys from rewrited query params...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/324#issuecomment-116354141
@supertinou sorry for the late answer.
> Is it possible to reference custom remote branches for the compilation of couchdb ?
yes that is possible, see https://github.com/robertkowalski/couchdb/blob/couchdb-perf-not-optimized/rebar.config.script#L25 for an example
you can also try to run the testsuite locally before submitting a PR:
`make javascript` should kick off the js testsuite (use `make eunit` for running the erlang testsuite)
https://github.com/apache/couchdb/blob/master/Makefile#L161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2722 Keys from rewrited query params...
Posted by supertinou <gi...@git.apache.org>.
Github user supertinou commented on the pull request:
https://github.com/apache/couchdb/pull/324#issuecomment-114378777
Thank you @robertkowalski.
As we are sadly not able to see the tests running with the fix I think I am going to make a new pull request only for testing purpose in which I will keep these tests and replace the master branch of couch and chttpd by the fixed branches COUCHDB-2722
https://github.com/apache/couchdb/blob/master/rebar.config.script#L25-26
What do you think about it?
*NB : And maybe no need to change the chttpd branch as the tests are only run against the old backdoor ports which are served by apache/couchdb-couch.*
Thanks again @robertkowalski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #324: COUCHDB-2722 Keys from rewrited query params should be b...
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the issue:
https://github.com/apache/couchdb/pull/324
@benel Yes thank you! Open a new PR and reference this one. I will close this one now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2722 Keys from rewrited query params...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/324#issuecomment-114311194
@supertinou wow thank you - you are awesome!
sadly i have to admit that i have not done much with rewritten query params, so let me ping @rnewson who might be a better reviewer than me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #324: COUCHDB-2722 Keys from rewrited query params should be b...
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the issue:
https://github.com/apache/couchdb/pull/324
Ping @supertinou . We'd love to merge this if you can run the tests and get back to us.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request #324: COUCHDB-2722 Keys from rewrited query params shou...
Posted by wohali <gi...@git.apache.org>.
Github user wohali closed the pull request at:
https://github.com/apache/couchdb/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2722 Keys from rewrited query params...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/324#issuecomment-122255948
@supertinou hi, what is the status on the issue? **friendly nudge**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---