You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/05/04 21:39:13 UTC

[GitHub] nifi pull request #2652: NIFI-5114: Added Basic auth support to WebSocket co...

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2652#discussion_r186227509
  
    --- Diff: nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java ---
    @@ -103,6 +107,35 @@
                 .defaultValue("10 sec")
                 .build();
     
    +    public static final PropertyDescriptor USER_NAME = new PropertyDescriptor.Builder()
    +            .name("user-name")
    +            .displayName("User Name")
    +            .description("The user name for Basic Authentication.")
    +            .required(false)
    +            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    +            .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor USER_PASSWORD = new PropertyDescriptor.Builder()
    +            .name("user-password")
    +            .displayName("User Password")
    +            .description("The user password for Basic Authentication.")
    +            .required(false)
    +            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    +            .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
    +            .sensitive(true)
    +            .build();
    +
    +    public static final PropertyDescriptor AUTH_CHARSET = new PropertyDescriptor.Builder()
    +            .name("authentication-charset")
    +            .displayName("Authentication Header Charset")
    +            .description("The charset for Basic Authentication header base64 string.")
    +            .required(true)
    +            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    +            .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
    +            .defaultValue("US-ASCII")
    --- End diff --
    
    Why not UTF-8?


---