You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/10/19 09:04:08 UTC
[PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
panbingkun opened a new pull request, #43454:
URL: https://github.com/apache/spark/pull/43454
### What changes were proposed in this pull request?
The pr aims to add Matomo analytics to pyspark docs pages.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually test.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43454:
URL: https://github.com/apache/spark/pull/43454#issuecomment-1770416033
After this PR, I will do similar things to the published documents in the Spark website code.
Including all documents, `non pyspark documents`, `pyspark documents`, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43454: [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages
URL: https://github.com/apache/spark/pull/43454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43454:
URL: https://github.com/apache/spark/pull/43454#issuecomment-1771871346
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43454:
URL: https://github.com/apache/spark/pull/43454#issuecomment-1771126516
<img width="955" alt="image" src="https://github.com/apache/spark/assets/15246973/f8246a11-e228-4c9a-bc97-c35b50f87672">
Double check, After this PR
2494(The number of all HTML files) = 2347 (the number of HTML files containing `Matomo analytics code`) + 147 (some image files automatically generated by sphinx)
Verification is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43454:
URL: https://github.com/apache/spark/pull/43454#issuecomment-1770409133
cc @zhengruifeng @itholic @allisonwang-db @HyukjinKwon @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45428][PYTHON][DOCS] Add Matomo analytics to pyspark docs pages [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43454:
URL: https://github.com/apache/spark/pull/43454#issuecomment-1771027624
> Is this template automatically used in docs? or is that what the future PRs will do?
Yes, when we currently use the sphinx mechanism to generate `pyspark documents`, it will use this overloaded template to help us automatically add the `Matomo analytics code` mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org