You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by wangyulin <gi...@git.apache.org> on 2018/06/08 11:08:03 UTC

[GitHub] commons-pool pull request #5: Delete repeated call startEvictor

GitHub user wangyulin opened a pull request:

    https://github.com/apache/commons-pool/pull/5

    Delete repeated call startEvictor

    Constructor of class `GenericKeyedObjectPool`, `public GenericKeyedObjectPool(final KeyedPooledObjectFactory<K, T> factory, final GenericKeyedObjectPoolConfig<T> config)`,The first call to the `startEvictor` in the `setConfig` method. 
    Class `GenericKeyedObjectPool` is a similar problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyulin/commons-pool master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-pool/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 38f7baee36ef1b452ddb16ae10ff8e224f6b7b2f
Author: jieyebing <ji...@...>
Date:   2018-06-08T10:58:54Z

    Ignore .idea/, .iml (intellij idea)

commit 118dac5415d4fac111971c53e29537863ee3e572
Author: jieyebing <ji...@...>
Date:   2018-06-08T10:59:14Z

    Remove repeat call startEvictor from construction method

commit 1b70f3026c44651ed909e09dc67dc6b35a89fee4
Author: jieyebing <ji...@...>
Date:   2018-06-08T10:59:35Z

    Remove repeat call startEvictor from construction method

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-pool issue #5: Delete repeated call startEvictor

Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:

    https://github.com/apache/commons-pool/pull/5
  
    @garydgregory  Consider whether the problem is reasonable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-pool issue #5: Delete repeated call startEvictor

Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:

    https://github.com/apache/commons-pool/pull/5
  
    Thank you for your patch. In git master now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-pool pull request #5: Delete repeated call startEvictor

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-pool/pull/5


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-pool issue #5: Delete repeated call startEvictor

Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:

    https://github.com/apache/commons-pool/pull/5
  
    @garydgregory Consider whether the problem is reasonable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org