You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 20:59:40 UTC
[GitHub] [arrow] sreeharihegden opened a new pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS [WIP]
sreeharihegden opened a new pull request #12342:
URL: https://github.com/apache/arrow/pull/12342
## Overview
This Pull Request:
- Enables building of the MATLAB Interface C++ code, running of the C++ tests, and running of the MATLAB tests using GitHub Actions on a `macos-latest` VM.
- This is also updating the old version `v0` of [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) enabled for `ubuntu-latest` VM to the lastest `v1` [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab).
## Implementation
This implementation uses [`matlab-actions`](https://github.com/matlab-actions) to automatically install MATLAB into a GitHub Actions Linux and Mac VM.
We are using the most updated version: `v1` [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) to enable the CI for Mac.
Here are the steps we require to build and run tests on Mac:
- Check out the repository
- Install ninja using the `brew` command
- Install MATLAB using [`matlab-actions/setup-matlab@v1`](https://github.com/matlab-actions/setup-matlab)
- Build MATLAB using the existing `matlab_build.sh` script in `ci/scripts`
- Set the `MATLABPATH` environment variable to the MATLAB Interface to Apache Arrow installation directory
- Run MATLAB tests in the folder `matlab/test` using [`matlab-actions/run-tests@v1`](https://github.com/matlab-actions/run-tests)
## Testing
1. The GitHub Actions workflows passed successfully with no errors in this [Job](https://github.com/mathworks/arrow/actions/runs/1796808254).
2. All C++ test results and MATLAB test results can be viewed in the workflow logs.
## Future Directions
Enable support for Windows: [`matlab-actions/setup-matlab@v1`](https://github.com/matlab-actions/setup-matlab) supports Windows now. We are working on enabling this for the MATLAB Arrow interface.
## Notes
1. This pull request depends on code from the pull request:
#12004
and so should be accepted only after that.
2. Thank you, Fiona @lafiona for helping me with this pull request to submit the changes for `matlab.yml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1032308310
Could you remove "Notes 1." from the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Finished :arrow_down:0.39% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12342:
URL: https://github.com/apache/arrow/pull/12342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#discussion_r801345357
##########
File path: .github/workflows/matlab.yml
##########
@@ -37,7 +37,7 @@ concurrency:
jobs:
- matlab:
+ matlab-ubuntu:
Review comment:
How about removing `matlab-` prefix because this file is only for MATLAB?
```suggestion
ubuntu:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Finished :arrow_down:0.39% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1030344861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1030813240
I've merged #12004. Could you rebase on master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sreeharihegden commented on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
sreeharihegden commented on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1032855830
> Could you remove "Notes 1." from the description?
Thank you, @kou, for the feedback.
I have made the necessary changes to the job ids in `matlab.yml` as well as updated "Notes" here as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12342: ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12342:
URL: https://github.com/apache/arrow/pull/12342#issuecomment-1033066347
Benchmark runs are scheduled for baseline = 09c8554d4189cec4da96f3a93266df5cb0718a41 and contender = ac2d8ff481816299e2b047bf8a4546baccc3d050. ac2d8ff481816299e2b047bf8a4546baccc3d050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8211b7cf41a40cca565a197a796a8cd...7bd4fc9f8b3949b48e6d7ba0a760b55a/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54d9df2152204a508b8f149469ebc4f9...6976e8bffdb94f1ca75a5178eeede3c8/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/973a1ca2e8eb4ead8f00e0d4d500dbe2...50d51cfd18a24646b583e0d606d2d66e/)
[Finished :arrow_down:0.39% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/91e25e83cc5a442687ae28fd171ede5b...b9513659490b4390943c3dc9729295f5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org