You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 12:39:00 UTC

[GitHub] [pulsar] tisonkun opened a new pull request, #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

tisonkun opened a new pull request, #18177:
URL: https://github.com/apache/pulsar/pull/18177

   This supersedes #17508.
   
   ### Motivation
   
   <!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
   
   ### Modifications
   
   <!-- Describe the modifications you've done. -->
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1289940989

   ping @BewareMyPower @RobertIndie @nicoloboschi @eolivelli @Jason918 tests passed. Although I can always reapply the formatting step, I hope with can have a timely review stage :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1288976810

   cc @BewareMyPower @RobertIndie 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1289896449

   
   /pulsarbot rerun-failure-checks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1289890713

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1315429246

   Hi, @tisonkun 
   I'm not sure If this change is acceptable for PMCs or needs to vote on. But there is some trouble with cherry-picking new changes to the previous branch.
   I'm wondering if we have a good method to resolve the conflict with the previous branch. maybe `mvn initialize license:format` can work properly? I'm not sure...
   Anyway, thanks a lot for your contribution, I hope you can answer my question though, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1315495548

   @mattisonchao This is not a breaking change from a user perspective. Thus, I don't initialize a formal vote.
   
   I made several discussions on the dev@ list:
   
   * https://lists.apache.org/thread/gwy3ycgsq24r784mk3yv6cbppmbfxgjd
   * https://lists.apache.org/thread/jxl6vlgdd460gnnno6o6kpyc4jqc0b2k
   
   ... and follow the common [lazy consensus principle](https://community.apache.org/committers/lazyConsensus.html).
   
   To resolve your issues, either run `mvn initialize license:format` on the failure PR, or manually append `*` for new files when cherry-picking.
   
   The new style is started from 2.12 or 2.11 and the whole style will converge finally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1289850002

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1317830296

   Ok, Got it. thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower merged pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #18177:
URL: https://github.com/apache/pulsar/pull/18177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1289863517

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18177?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18177](https://codecov.io/gh/apache/pulsar/pull/18177?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7dfb11c) into [master](https://codecov.io/gh/apache/pulsar/commit/6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c65ca0) will **decrease** coverage by `8.87%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/18177/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/18177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18177      +/-   ##
   ============================================
   - Coverage     34.91%   26.03%   -8.88%     
   + Complexity     5707     3429    -2278     
   ============================================
     Files           607      398     -209     
     Lines         53396    43552    -9844     
     Branches       5712     4474    -1238     
   ============================================
   - Hits          18644    11340    -7304     
   + Misses        32119    30440    -1679     
   + Partials       2633     1772     -861     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `26.03% <0.00%> (-8.88%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/pulsar/PulsarBrokerStarter.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckJyb2tlclN0YXJ0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../org/apache/pulsar/PulsarClusterMetadataSetup.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckNsdXN0ZXJNZXRhZGF0YVNldHVwLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...g/apache/pulsar/PulsarClusterMetadataTeardown.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckNsdXN0ZXJNZXRhZGF0YVRlYXJkb3duLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...org/apache/pulsar/PulsarInitialNamespaceSetup.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckluaXRpYWxOYW1lc3BhY2VTZXR1cC5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../main/java/org/apache/pulsar/PulsarStandalone.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhclN0YW5kYWxvbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ava/org/apache/pulsar/PulsarStandaloneBuilder.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhclN0YW5kYWxvbmVCdWlsZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...ava/org/apache/pulsar/PulsarStandaloneStarter.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhclN0YW5kYWxvbmVTdGFydGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...sar/PulsarTransactionCoordinatorMetadataSetup.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhclRyYW5zYWN0aW9uQ29vcmRpbmF0b3JNZXRhZGF0YVNldHVwLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...n/java/org/apache/pulsar/PulsarVersionStarter.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhclZlcnNpb25TdGFydGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...ava/org/apache/pulsar/broker/admin/v2/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [337 more](https://codecov.io/gh/apache/pulsar/pull/18177/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #18177: [improve][build] use SLASHSTAR_STYLE for licenses in Java files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18177:
URL: https://github.com/apache/pulsar/pull/18177#issuecomment-1290027791

   Thanks for merging this patch. Be aware that we may suffer a period that new patches introduce regression for the JAVADOC_STYLE license header because we don't require the patch to be merged must be up-to-date. But the overall situation should converge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org