You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/09/01 15:38:46 UTC
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-epi/pull/7
Use function_exported/3 to test for callbacks
try/catch is much slower in comparison to function_exported.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-epi use-function-exported
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-epi/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 30cf24d3ad16d869a8cb68da7924c128e2f35c0d
Author: Robert Newson <rn...@apache.org>
Date: 2015-09-01T13:36:44Z
Use function_exported/3 to test for callbacks
try/catch is much slower in comparison to function_exported.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136737729
ah good catch, missed those
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136724781
this fixes a performance regression from the introduction of couch_epi.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136768566
ilya to follow up with better fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136731729
Good catch. Never liked try/catch. May be fix other modules as well? So far:
- couch_epi_data:get_from_module/1
- couch_epi_data:current/2
- couch_epi_data_source:current/2
- couch_epi_functions_gen:get_current_definitions/1
- couch_epi_functions_gen:get_current_is_updated/3
- couch_epi_functions_gen:dispatch/5
- couch_epi_functions_gen:provides/4
I think generic catch Class:Reason should be also revised, but didn't dig into to say for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb-couch-epi/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Use function_exported/3 to test fo...
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136731843
This two probably need the same treatment:
https://github.com/apache/couchdb-couch-epi/blob/master/src/couch_epi_data.erl#L137-L142
https://github.com/apache/couchdb-couch-epi/blob/master/src/couch_epi_functions_gen.erl#L253-L259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---