[jira] [Commented] (HIVE-15053) Beeline#addlocaldriver - reduce classpath scanning

["Peter Vary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167673#comment-16167673 ] 

Peter Vary commented on HIVE-15053:
-----------------------------------

[~kgyrtkirk]: Looking at your patch, I like how it simplifies the code. My only concern, that it can be an incompatible change if someone uses driver which is not service loadable. I would value [~Ferd]'s opinion on this since he is the original author of HIVE-9302 which introduced this feature.

Thanks,
Peter

> Beeline#addlocaldriver - reduce classpath scanning
> --------------------------------------------------
>
>                 Key: HIVE-15053
>                 URL: https://issues.apache.org/jira/browse/HIVE-15053
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-15053.1.patch, HIVE-15053.1.patch, HIVE-15053.1.patch, HIVE-15053.2.patch, HIVE-15053.3.patch
>
>
> There is a classpath scanning machinery inside {{ClassNameCompleter}}.
> I think the sole purpose of these things is to scan for jdbc drivers...(but not entirely sure)
> if it is indeed looking for jdbc drivers..then possibly this can be removed without any issues because modern jdbc drivers usually advertise their driver as a service-loadable class for {{java.sql.Driver}}
> http://www.onjava.com/2006/08/02/jjdbc-4-enhancements-in-java-se-6.html
> Auto-Loading of JDBC Driver



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)