You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/28 18:40:22 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #20491: Refactor: Remove unnecessary database commit and exception stack printing

potiuk commented on a change in pull request #20491:
URL: https://github.com/apache/airflow/pull/20491#discussion_r776030612



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -684,7 +684,7 @@ def _execute(self) -> None:
 
             settings.Session.remove()  # type: ignore
         except Exception:
-            self.log.exception("Exception when executing SchedulerJob._run_scheduler_loop")
+            self.log.error("Exception when executing SchedulerJob._run_scheduler_loop")

Review comment:
       Yep. I checked and there does not sem to be any caller - and still we want to log thiss one to scheduler logger. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org