You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Andi Huber (JIRA)" <ji...@apache.org> on 2017/10/06 15:37:00 UTC

[jira] [Commented] (ISIS-1743) faIcon mapping for mixin provided methods not honored intuitively

    [ https://issues.apache.org/jira/browse/ISIS-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194748#comment-16194748 ] 

Andi Huber commented on ISIS-1743:
----------------------------------

Patch is on my fork
https://github.com/andi-huber/isis/commit/78c8c55549894d888bc8f6c6c5aa98afb33b1d34

> faIcon mapping for mixin provided methods not honored intuitively
> -----------------------------------------------------------------
>
>                 Key: ISIS-1743
>                 URL: https://issues.apache.org/jira/browse/ISIS-1743
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.15.1
>            Reporter: Andi Huber
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> This example will not have the Action displayed with the font-awesome icon as mapped by e.g. remove.*:fa-minus-square ...
> {code:java}
> @Mixin
> public class SimpleObject_removeEntries {
> 	...
> 	@Action
> 	public SimpleObject $$(	List<Entry> entries	) {
> 		...
> 		
> 		return holder;
> 	}
> }
> {code}
> I believe this is counter-intuitive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)