You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2024/12/21 01:39:48 UTC
(kafka) branch 4.0 updated (1ab598b8edb -> a001a962182)
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a change to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
from 1ab598b8edb KAFKA-13722: code cleanup after deprecated StateStore.init() was removed (#18249)
new 8902aa3e1e4 KAFKA-18270: SaslHandshake v0 incorrectly tagged as deprecated (#18221)
new cb9ba69a603 KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (#18262)
new a001a962182 KAFKA-18334: Produce v4-v6 should be undeprecated (#18288)
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
clients/src/main/resources/common/message/FindCoordinatorRequest.json | 1 -
clients/src/main/resources/common/message/ProduceRequest.json | 2 +-
clients/src/main/resources/common/message/SaslHandshakeRequest.json | 1 -
core/src/test/scala/unit/kafka/network/SocketServerTest.scala | 2 +-
4 files changed, 2 insertions(+), 4 deletions(-)
(kafka) 02/03: KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (#18262)
Posted by ij...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit cb9ba69a603d880628f9e1f874aa5ff821d854bc
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Thu Dec 19 06:25:17 2024 -0800
KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (#18262)
It's now consistent with KIP-896.
---
clients/src/main/resources/common/message/FindCoordinatorRequest.json | 1 -
1 file changed, 1 deletion(-)
diff --git a/clients/src/main/resources/common/message/FindCoordinatorRequest.json b/clients/src/main/resources/common/message/FindCoordinatorRequest.json
index 69e154d1252..7a926501f7b 100644
--- a/clients/src/main/resources/common/message/FindCoordinatorRequest.json
+++ b/clients/src/main/resources/common/message/FindCoordinatorRequest.json
@@ -31,7 +31,6 @@
// Version 6 adds support for share groups (KIP-932).
// For key type SHARE (2), the coordinator key format is "groupId:topicId:partition".
"validVersions": "0-6",
- "deprecatedVersions": "0",
"flexibleVersions": "3+",
"fields": [
{ "name": "Key", "type": "string", "versions": "0-3",
(kafka) 03/03: KAFKA-18334: Produce v4-v6 should be undeprecated (#18288)
Posted by ij...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit a001a9621821d154aad953b3b908bcb4cac2aad2
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Fri Dec 20 16:59:51 2024 -0800
KAFKA-18334: Produce v4-v6 should be undeprecated (#18288)
Librdkafka totally breaks if produce v3 is removed - it starts sending records with record format v0.
These api versions have to be undeprecated - KIP-896 has been updated.
Reviewers: David Arthur <mu...@gmail.com>
---
clients/src/main/resources/common/message/ProduceRequest.json | 2 +-
core/src/test/scala/unit/kafka/network/SocketServerTest.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/clients/src/main/resources/common/message/ProduceRequest.json b/clients/src/main/resources/common/message/ProduceRequest.json
index 2bec066fad5..df83e7c172a 100644
--- a/clients/src/main/resources/common/message/ProduceRequest.json
+++ b/clients/src/main/resources/common/message/ProduceRequest.json
@@ -43,7 +43,7 @@
// AddPartitionsToTxn call. If V2 is disabled, the client can't use produce request version higher than 11 within
// a transaction.
"validVersions": "0-12",
- "deprecatedVersions": "0-6",
+ "deprecatedVersions": "0-2",
"flexibleVersions": "9+",
"fields": [
{ "name": "TransactionalId", "type": "string", "versions": "3+", "nullableVersions": "3+", "default": "null", "entityType": "transactionalId",
diff --git a/core/src/test/scala/unit/kafka/network/SocketServerTest.scala b/core/src/test/scala/unit/kafka/network/SocketServerTest.scala
index 362796381c2..586b8253a3d 100644
--- a/core/src/test/scala/unit/kafka/network/SocketServerTest.scala
+++ b/core/src/test/scala/unit/kafka/network/SocketServerTest.scala
@@ -346,7 +346,7 @@ class SocketServerTest {
assertTrue(requestsPerSec(requestVersion).getOrElse(0L) > 0, "RequestsPerSec should be higher than 0")
assertEquals(None, deprecatedRequestsPerSec(requestVersion))
- requestVersion = 3
+ requestVersion = 2
sendRequest(plainSocket, producerRequestBytes(requestVersion))
receivedReq = receiveRequest(server.dataPlaneRequestChannel)
server.dataPlaneRequestChannel.sendNoOpResponse(receivedReq)
(kafka) 01/03: KAFKA-18270: SaslHandshake v0 incorrectly tagged as deprecated (#18221)
Posted by ij...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit 8902aa3e1e4c8e3c05097a05c3669d8e047bdedd
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Mon Dec 16 20:52:30 2024 -0800
KAFKA-18270: SaslHandshake v0 incorrectly tagged as deprecated (#18221)
It's now consistent with KIP-896.
Reviewers: David Arthur <mu...@gmail.com>
---
clients/src/main/resources/common/message/SaslHandshakeRequest.json | 1 -
1 file changed, 1 deletion(-)
diff --git a/clients/src/main/resources/common/message/SaslHandshakeRequest.json b/clients/src/main/resources/common/message/SaslHandshakeRequest.json
index 3339f6a7afd..a370a80df39 100644
--- a/clients/src/main/resources/common/message/SaslHandshakeRequest.json
+++ b/clients/src/main/resources/common/message/SaslHandshakeRequest.json
@@ -23,7 +23,6 @@
// client negotiation for clients <= 2.4.
// See https://issues.apache.org/jira/browse/KAFKA-9577
"validVersions": "0-1",
- "deprecatedVersions": "0",
"flexibleVersions": "none",
"fields": [
{ "name": "Mechanism", "type": "string", "versions": "0+",