[jira] [Commented] (SOLR-7115) UpdateLog can miss closing transaction log objects.

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273103#comment-15273103 ] 

Mark Miller commented on SOLR-7115:
-----------------------------------

I see this consistently trying to update to hadoop 2.7.2.

I traced in and it seems like the problem is that on close, the following call in commit can hang and keep the post commit updatelog code from being called. Oddly, this hang doesn't seem to last because the test does not complain about the thread remaining.

{code}
              RefCounted<SolrIndexSearcher> searchHolder = core.openNewSearcher(true, true);
              searchHolder.decref();
{code}

Checking if the core is closed before calling that seems to help.

> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
>                 Key: SOLR-7115
>                 URL: https://issues.apache.org/jira/browse/SOLR-7115
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>
> I've seen this happen on YourKit and in various tests - especially since adding resource release tracking to the log objects. Now I've got a test that catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it because we are going to overwrite prevTlog with a new log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org