You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gary Kind (JIRA)" <de...@myfaces.apache.org> on 2007/07/13 20:39:05 UTC
[jira] Created: (TRINIDAD-102) Attempt to get the value of a custom
property from a node that has no custom properties causes NPE
Attempt to get the value of a custom property from a node that has no custom properties causes NPE
--------------------------------------------------------------------------------------------------
Key: TRINIDAD-102
URL: https://issues.apache.org/jira/browse/TRINIDAD-102
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Gary Kind
Attachments: trunk.patch
If XMLMenuModel.getCustomProperty() is called, the code gets a map from the node that contains its custom properties. If the node has no custom properties, the map returned is null. That case is not checked for, assuming the map to be valid and non-empty, causing an NPE. The attached patch file fixes this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-102) Attempt to get the value of a
custom property from a node that has no custom properties causes NPE
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer resolved TRINIDAD-102.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.2-core
Assignee: Adam Winer
Thanks, looks good. Checked in!
> Attempt to get the value of a custom property from a node that has no custom properties causes NPE
> --------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-102
> URL: https://issues.apache.org/jira/browse/TRINIDAD-102
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Assignee: Adam Winer
> Fix For: 1.0.2-core
>
> Attachments: trunk.patch, trunk.patch
>
>
> If XMLMenuModel.getCustomProperty() is called, the code gets a map from the node that contains its custom properties. If the node has no custom properties, the map returned is null. That case is not checked for, assuming the map to be valid and non-empty, causing an NPE. The attached patch file fixes this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-102) Attempt to get the value of a
custom property from a node that has no custom properties causes NPE
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513026 ]
Adam Winer commented on TRINIDAD-102:
-------------------------------------
The patch has a bunch of unrelated changes, including deleting some desired recent changes. Please submit a patch only including the fix here.
> Attempt to get the value of a custom property from a node that has no custom properties causes NPE
> --------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-102
> URL: https://issues.apache.org/jira/browse/TRINIDAD-102
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Attachments: trunk.patch
>
>
> If XMLMenuModel.getCustomProperty() is called, the code gets a map from the node that contains its custom properties. If the node has no custom properties, the map returned is null. That case is not checked for, assuming the map to be valid and non-empty, causing an NPE. The attached patch file fixes this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-102) Attempt to get the value of a custom
property from a node that has no custom properties causes NPE
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated TRINIDAD-102:
--------------------------------
Status: Open (was: Patch Available)
> Attempt to get the value of a custom property from a node that has no custom properties causes NPE
> --------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-102
> URL: https://issues.apache.org/jira/browse/TRINIDAD-102
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Attachments: trunk.patch
>
>
> If XMLMenuModel.getCustomProperty() is called, the code gets a map from the node that contains its custom properties. If the node has no custom properties, the map returned is null. That case is not checked for, assuming the map to be valid and non-empty, causing an NPE. The attached patch file fixes this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-102) Attempt to get the value of a custom
property from a node that has no custom properties causes NPE
Posted by "Gary Kind (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Kind updated TRINIDAD-102:
-------------------------------
Status: Patch Available (was: Open)
> Attempt to get the value of a custom property from a node that has no custom properties causes NPE
> --------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-102
> URL: https://issues.apache.org/jira/browse/TRINIDAD-102
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Attachments: trunk.patch
>
>
> If XMLMenuModel.getCustomProperty() is called, the code gets a map from the node that contains its custom properties. If the node has no custom properties, the map returned is null. That case is not checked for, assuming the map to be valid and non-empty, causing an NPE. The attached patch file fixes this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.