You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/03 06:14:23 UTC

[GitHub] [arrow] Dandandan commented on pull request #9070: ARROW-11030: [Rust][DataFusion] Concatenate left side batches to single batch in HashJoinExec

Dandandan commented on pull request #9070:
URL: https://github.com/apache/arrow/pull/9070#issuecomment-753574211


   @andygrove @jorgecarleitao 
   
   Is now ready for review. 
   I added some comments myself too.
   
   The PR now includes the following:
   
   * The main change to collect into 1 batch, and use `take` directly
   * Build info about column indexes upfront
   * Speed improvement in `create_key` (doing `row.value(i)` twice most importantly), this also makes q1 and q5 run a bit faster
   * Misc refactoring
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org