You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:09:33 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #25684: Add 'executor' label to airflow scheduler deployment

jedcunningham commented on code in PR #25684:
URL: https://github.com/apache/airflow/pull/25684#discussion_r986067370


##########
tests/charts/test_scheduler.py:
##########
@@ -674,6 +674,25 @@ def test_persistence_volume_annotations(self):
         )
         assert {"foo": "bar"} == jmespath.search("spec.volumeClaimTemplates[0].metadata.annotations", docs[0])
 
+    @parameterized.expand(
+        "executor",
+        [
+            ("LocalExecutor"),
+            ("LocalKubernetesExecutor"),
+            ("CeleryExecutor"),
+            ("KubernetesExecutor"),
+            ("CeleryKubernetesExecutor"),
+        ],

Review Comment:
   ```suggestion
           [
               "LocalExecutor",
               "LocalKubernetesExecutor",
               "CeleryExecutor",
               "KubernetesExecutor",
               "CeleryKubernetesExecutor",
           ]
   ```
   
   This will fix one of them at least.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org