You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/09 12:25:41 UTC
[GitHub] [hudi] yanghua commented on a change in pull request #1871: [HUDI-781] Introduce HoodieTestTable for test preparation
yanghua commented on a change in pull request #1871:
URL: https://github.com/apache/hudi/pull/1871#discussion_r467530658
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FilesTestUtils.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.testutils;
+
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.IOType;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+public class FilesTestUtils {
Review comment:
IMO, The name of this class may make readers confused? It seems to represent that it is a utility class about testing file function. WDYT about renaming it to `FileMockUtils`?
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -307,31 +299,26 @@ public static String createNewLogFile(FileSystem fs, String basePath, String par
return fileID;
}
- public static void createCompactionCommitFiles(FileSystem fs, String basePath, String... instantTimes)
- throws IOException {
- for (String instantTime : instantTimes) {
- boolean createFile = fs.createNewFile(new Path(basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME + "/"
- + HoodieTimeline.makeCommitFileName(instantTime)));
- if (!createFile) {
- throw new IOException("cannot create commit file for commit " + instantTime);
- }
- }
- }
-
public static void createCompactionRequest(HoodieTableMetaClient metaClient, String instant,
- List<Pair<String, FileSlice>> fileSliceList) throws IOException {
+ List<Pair<String, FileSlice>> fileSliceList) throws IOException {
Review comment:
Does this indentation style break the rule of the project?
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FilesTestUtils.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.testutils;
+
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.IOType;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+public class FilesTestUtils {
+
+ private static void fakeMetaFile(String basePath, String instantTime, String suffix) throws IOException {
+ String parentPath = basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME;
+ new File(parentPath).mkdirs();
+ new File(parentPath + "/" + instantTime + suffix).createNewFile();
+ }
+
+ public static void fakeCommit(String basePath, String instantTime) throws IOException {
Review comment:
IMO, `mock` is a better naming than `fake`. `mock` is a more generic term in test field. Just a thought.
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FilesTestUtils.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.testutils;
+
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.IOType;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+public class FilesTestUtils {
+
+ private static void fakeMetaFile(String basePath, String instantTime, String suffix) throws IOException {
+ String parentPath = basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME;
+ new File(parentPath).mkdirs();
+ new File(parentPath + "/" + instantTime + suffix).createNewFile();
+ }
+
+ public static void fakeCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.COMMIT_EXTENSION);
+ }
+
+ public static void fakeRequestedCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.REQUESTED_COMMIT_EXTENSION);
+ }
+
+ public static void fakeInflightCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.INFLIGHT_COMMIT_EXTENSION);
+ }
+
+ public static void fakeDeltaCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.DELTA_COMMIT_EXTENSION);
+ }
+
+ public static void fakeRequestedDeltaCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.REQUESTED_DELTA_COMMIT_EXTENSION);
+ }
+
+ public static void fakeInflightDeltaCommit(String basePath, String instantTime) throws IOException {
+ fakeMetaFile(basePath, instantTime, HoodieTimeline.INFLIGHT_DELTA_COMMIT_EXTENSION);
+ }
+
+ public static void fakeDataFile(String basePath, String partitionPath, String instantTime, String fileId)
+ throws Exception {
+ fakeDataFile(basePath, partitionPath, instantTime, fileId, 0);
+ }
+
+ public static void fakeDataFile(String basePath, String partitionPath, String instantTime, String fileId, long length)
+ throws Exception {
+ String parentPath = String.format("%s/%s", basePath, partitionPath);
+ new File(parentPath).mkdirs();
Review comment:
Using `Files.createFile(...)` may be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org