[GitHub] [shardingsphere] RaigorJiang opened a new issue, #25113: Optimize usage of PostgreSQLDatabaseType and OpenGaussDatabaseType

["RaigorJiang (via GitHub)" <gi...@apache.org>]

RaigorJiang opened a new issue, #25113:
URL: https://github.com/apache/shardingsphere/issues/25113

   At present, there are many logics in the project that use `OpenGaussDatabaseType` for judgment.
   It needs to work in the way of `PostgreSQL` in the openGauss scenario.
   
   For example `SystemSchemaBuilder`:
   ```
   private static Collection<String> getSystemSchemas(final String originalDatabaseName, final DatabaseType databaseType) {
            String databaseName = databaseType instanceof PostgreSQLDatabaseType || databaseType instanceof OpenGaussDatabaseType ? "postgres" : originalDatabaseName;
            return databaseType.getSystemDatabaseSchemaMap().getOrDefault(databaseName, Collections.emptyList());
        }
   ```
   
   Considering that both `PostgreSQLDatabaseType` and `OpenGaussDatabaseType` implement `SchemaSupportedDatabaseType` (no other implementations), I think it would be better to unify the type judgment as `SchemaSupportedDatabaseType`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed issue #25113: Optimize usage of PostgreSQLDatabaseType and OpenGaussDatabaseType

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu closed issue #25113: Optimize usage of PostgreSQLDatabaseType and OpenGaussDatabaseType
URL: https://github.com/apache/shardingsphere/issues/25113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org