You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/08/07 06:15:50 UTC
[PR] [UUID 4b] Bloom filter segment pruning for the logical UUID type [pinot]
xiangfu0 opened a new pull request, #19182:
URL: https://github.com/apache/pinot/pull/19182
## What
Makes `BloomFilterSegmentPruner` able to prune segments for `UUID` columns.
## The problem
The pruner probed the bloom filter with `_comparableValue.toString()`. For a UUID predicate the comparable value is a `ByteArray`, so the probe string was `ByteArray`'s representation and never matched a real entry — the pruner silently never pruned a UUID column.
This is **not a correctness bug**: a bloom-filter miss only ever means a segment isn't pruned, so results were always right. It just made the pruner dead weight for UUID predicates.
## The fix
`BloomFilterCreator.add(Object, int)` is the write-side contract the reader has to mirror, and it renders a UUID as its canonical dashed string. The pruner now does the same. The rendering is resolved **once at construction** rather than on every `mightBeContained()` call, so the scan path is unchanged.
## Scope
Deliberately UUID-only. `BIG_DECIMAL` has the same class of divergence — `DataType#toString` uses `toPlainString()` while the creator uses `value.toString()`, so they disagree on trailing zeros — but fixing that changes pruning behaviour for existing tables and deserves its own PR.
## Testing
`BloomFilterSegmentPrunerTest` gains UUID coverage for the prune and no-prune paths, including the mixed-case and dashless input forms that must normalise to the same key.
## About this PR
Split out of #18872. Depends only on `UuidUtils` (#18869), already on master — independent of #18872 and #19181, mergeable on its own.
Part of the #18140 UUID split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter support for the logical UUID type [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19182:
URL: https://github.com/apache/pinot/pull/19182#discussion_r3739248291
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
Review Comment:
Updated. The repurposed PR description no longer characterizes a mismatched Bloom probe as harmless. It now documents the shared stored-byte hex representation, and the CustomIntegration test verifies that present UUIDs are not falsely pruned.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
+
+ /// Renders the value exactly as `BloomFilterCreator#add(Object, int)` did when the index was built. If the
+ /// two disagree the lookup silently misses and the segment is wrongly pruned, dropping matching rows with no
+ /// error. That creator special-cases UUID to the canonical string and renders everything else with
+ /// `value.toString()` -- which for BYTES is already hex via [ByteArray].
+ ///
+ /// Deliberately NOT routed through `DataType#toString`: that renders BIG_DECIMAL with
+ /// `toPlainString()`, which the creator does not, so every BIG_DECIMAL bloom filter would start missing.
+ private String bloomFilterKey() {
+ return _dt == DataType.UUID ? UuidUtils.toString((ByteArray) _comparableValue)
Review Comment:
Done. UUID now reuses the stored `BYTES` representation: `BloomFilterCreator` dispatches through `getStoredType()` and writes lowercase dashless hex. Query UUID values normalize to the same byte-backed hex key, so `ValueBasedSegmentPruner` needs no UUID-specific rendering.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
+
+ /// Renders the value exactly as `BloomFilterCreator#add(Object, int)` did when the index was built. If the
+ /// two disagree the lookup silently misses and the segment is wrongly pruned, dropping matching rows with no
+ /// error. That creator special-cases UUID to the canonical string and renders everything else with
+ /// `value.toString()` -- which for BYTES is already hex via [ByteArray].
+ ///
+ /// Deliberately NOT routed through `DataType#toString`: that renders BIG_DECIMAL with
+ /// `toPlainString()`, which the creator does not, so every BIG_DECIMAL bloom filter would start missing.
+ private String bloomFilterKey() {
+ return _dt == DataType.UUID ? UuidUtils.toString((ByteArray) _comparableValue)
Review Comment:
Done. UUID now reuses the stored `BYTES` representation: `BloomFilterCreator` dispatches through `getStoredType()` and writes lowercase dashless hex. Query UUID values normalize to the same byte-backed hex key, so `ValueBasedSegmentPruner` needs no UUID-specific rendering.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
Review Comment:
Updated. The repurposed PR description no longer characterizes a mismatched Bloom probe as harmless. It now documents the shared stored-byte hex representation, and the CustomIntegration test verifies that present UUIDs are not falsely pruned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter support for the logical UUID type [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #19182:
URL: https://github.com/apache/pinot/pull/19182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter support for the logical UUID type [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #19182:
URL: https://github.com/apache/pinot/pull/19182#discussion_r3739266982
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java:
##########
@@ -286,7 +287,7 @@ private void createBloomFilterForColumn(SegmentDirectory.Writer segmentWriter, C
private Dictionary getDictionaryReader(ColumnMetadata columnMetadata, SegmentDirectory.Writer segmentWriter)
throws IOException {
- DataType dataType = columnMetadata.getDataType();
+ DataType dataType = columnMetadata.getDataType().getStoredType();
Review Comment:
Rename it to `storedType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter segment pruning for the logical UUID type [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19182:
URL: https://github.com/apache/pinot/pull/19182#issuecomment-5213732954
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19182?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.13%. Comparing base ([`d3604a5`](https://app.codecov.io/gh/apache/pinot/commit/d3604a585db46dcf75691887b9e9d3c7f91721d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0025825`](https://app.codecov.io/gh/apache/pinot/commit/002582585bc2ffa6310881002d4aa1084b71cdcd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (d3604a5) and HEAD (0025825). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (d3604a5) | HEAD (0025825) |
>|------|------|------|
>|unittests|2|1|
>|java-25|5|1|
>|temurin|5|1|
>|unittests2|1|0|
>|integration|3|0|
>|integration1|1|0|
>|integration2|1|0|
>|custom-integration1|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19182 +/- ##
============================================
- Coverage 66.62% 57.13% -9.49%
+ Complexity 1423 1 -1422
============================================
Files 3443 2646 -797
Lines 218577 158906 -59671
Branches 34792 26115 -8677
============================================
- Hits 145624 90798 -54826
+ Misses 61218 60325 -893
+ Partials 11735 7783 -3952
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.13% <100.00%> (-9.49%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.13% <100.00%> (-9.49%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.13% <100.00%> (-9.49%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.13% <100.00%> (+0.01%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19182?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter segment pruning for the logical UUID type [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #19182:
URL: https://github.com/apache/pinot/pull/19182#discussion_r3738425411
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
Review Comment:
The PR description states this was “not a correctness bug” because a bloom-filter miss “only ever means a segment isn't pruned”. However, the pruning logic prunes a segment when `mightBeContained()` is false (bloom-filter miss), so probing the bloom filter with a differently-rendered key can prune segments that actually contain matching rows. Please update/clarify the PR description accordingly so readers don’t underestimate the impact.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
+
+ /// Renders the value exactly as `BloomFilterCreator#add(Object, int)` did when the index was built. If the
+ /// two disagree the lookup silently misses and the segment is wrongly pruned, dropping matching rows with no
+ /// error. That creator special-cases UUID to the canonical string and renders everything else with
+ /// `value.toString()` -- which for BYTES is already hex via [ByteArray].
+ ///
+ /// Deliberately NOT routed through `DataType#toString`: that renders BIG_DECIMAL with
+ /// `toPlainString()`, which the creator does not, so every BIG_DECIMAL bloom filter would start missing.
Review Comment:
The comment implies BloomFilterCreator renders “everything else” via `value.toString()` and that this is safe for BYTES because of `ByteArray`. However, BloomFilterCreator actually special-cases BYTES and expects a `byte[]` (where `toString()` would be `[B@...`), so the current wording is misleading and could cause a future regression if someone refactors based on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter support for the logical UUID type [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #19182:
URL: https://github.com/apache/pinot/pull/19182#issuecomment-5223007391
Addressed the remaining review question about what is inserted into the Bloom filter:
- UUID ingestion normalizes values to the 16-byte stored representation.
- `BloomFilterCreator` dispatches on `getStoredType()`; UUID therefore follows the `BYTES` path.
- The Bloom key is `BytesUtils.toHexString(byte[])`, i.e. lowercase dashless hex.
- Query literals (dashless hex or `CAST(canonical AS UUID)`) normalize to the same bytes/hex key.
The new `UuidBloomFilterTest` validates both query forms through a real cluster and asserts that present segments are processed while an absent in-range UUID is Bloom-pruned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter segment pruning for the logical UUID type [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #19182:
URL: https://github.com/apache/pinot/pull/19182#discussion_r3738525197
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ValueBasedSegmentPruner.java:
##########
@@ -230,15 +232,30 @@ public void ensureDataType(DataType dt) {
}
public boolean mightBeContained(BloomFilterReader bloomFilter) {
+ // The rendering and hashing below run once per (value, data type): the resulting hashes are memoized and
+ // every subsequent segment in the query reuses them. Deliberately not precomputed in ensureDataType, so a
+ // query that only reaches min/max pruning never pays for it.
if (!_hashed) {
GuavaBloomFilterReaderUtils.Hash128AsLongs hash128AsLongs =
- GuavaBloomFilterReaderUtils.hashAsLongs(_comparableValue.toString());
+ GuavaBloomFilterReaderUtils.hashAsLongs(bloomFilterKey());
_hash1 = hash128AsLongs.getHash1();
_hash2 = hash128AsLongs.getHash2();
_hashed = true;
}
return bloomFilter.mightContain(_hash1, _hash2);
}
+
+ /// Renders the value exactly as `BloomFilterCreator#add(Object, int)` did when the index was built. If the
+ /// two disagree the lookup silently misses and the segment is wrongly pruned, dropping matching rows with no
+ /// error. That creator special-cases UUID to the canonical string and renders everything else with
+ /// `value.toString()` -- which for BYTES is already hex via [ByteArray].
+ ///
+ /// Deliberately NOT routed through `DataType#toString`: that renders BIG_DECIMAL with
+ /// `toPlainString()`, which the creator does not, so every BIG_DECIMAL bloom filter would start missing.
+ private String bloomFilterKey() {
+ return _dt == DataType.UUID ? UuidUtils.toString((ByteArray) _comparableValue)
Review Comment:
We need a canonical format. When query comes, we also convert the value into canonical format. Should we just use hex as canonical format (i.e. use stored type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UUID 4b] Bloom filter support for the logical UUID type [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19182:
URL: https://github.com/apache/pinot/pull/19182#discussion_r3739367612
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java:
##########
@@ -286,7 +287,7 @@ private void createBloomFilterForColumn(SegmentDirectory.Writer segmentWriter, C
private Dictionary getDictionaryReader(ColumnMetadata columnMetadata, SegmentDirectory.Writer segmentWriter)
throws IOException {
- DataType dataType = columnMetadata.getDataType();
+ DataType dataType = columnMetadata.getDataType().getStoredType();
Review Comment:
Renamed the local variable to `storedType` and updated the switch and error message consistently in commit 19a0bedd3d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org