You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (Jira)" <ji...@apache.org> on 2019/11/12 18:02:00 UTC
[jira] [Comment Edited] (YARN-9052) Replace all MockRM submit
method definitions with a builder
[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972669#comment-16972669 ]
Szilard Nemeth edited comment on YARN-9052 at 11/12/19 6:01 PM:
----------------------------------------------------------------
Thanks [~sunilg]!
Right now, I'm in the process of adding some logs to all parameters so that I can be confident my change won't break anything.
The main patch will also contain the same logging, so if something is different in the test results, I can see which field it was the culprit.
Do you know if I can download test logs for all testcases from Jenkins?
was (Author: snemeth):
Thanks [~sunilg]!
Right now, I'm in the process of adding some logs to all parameters so that I can be confident my change won't break anything.
The main patch will also contain the same logging, so if something is different in the test results, I can see which field it was the culprit.
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-9052.001.patch, YARN-9052.002.patch, YARN-9052.003.patch, YARN-9052.testlogs.002.patch, YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than acceptable number of parameters, ranging from 2 to even 22 parameters, which makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org