You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/03/06 13:55:43 UTC
[GitHub] [lucene-solr] dsmiley commented on issue #581: LUCENE-3041:
QueryVisitor
dsmiley commented on issue #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#issuecomment-470115757
I'm not sure if my comment got lost somewhere but I strongly feel that Query.visit should be an abstract method. Each subclass ought to determine what to do; we don't know a suitable default choice. By having a default choice, we let things slip through... for example this patch has forgotten about the surround query parser's Query subclasses, and forgetting this means that these queries aren't highlighted by the UnifiedHighlighter. However on the backport to 8x I can see the need to implement a default method for backwards compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org