You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/09/05 23:11:51 UTC
Review Request 62101: SENTRY-1916 Sentry should not store paths
outside of the prefix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62101/
-----------------------------------------------------------
Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, and Vadim Spector.
Bugs: SENTRY-1916
https://issues.apache.org/jira/browse/SENTRY-1916
Repository: sentry
Description
-------
SENTRY-1916 Sentry should not store paths outside of the prefix
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java 55092eec04d86b64aa91e30e76bb63c40b2a375b
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 551f184c35c8c3bf4e4b49aa540a55b016bb9a32
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java d62196f7c869aa088db4f9d110a9c4d94387ac14
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java 25019708411c66c43700f7219b4059dd31af80a3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java 713fc3d135fe1a6a0c0d30ef9610540d350aa782
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PathValidator.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 6ec163b1d802810287a55bc5cd98409bc73e8ba8
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateInitializer.java 589acbed12855ff09309a04c9214f8daf87ea1de
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java a8fcbf8f36482661bb40adf481105af4e4438689
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java 00f9b3959b7ccf9d046c422a007ff375eddba076
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java 38668ca88f155e0fa2f3beb4db32b18e953e58b6
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java acf1cf5e2a9ba1cfaef9ccc404e56791c10b4be9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 63e718cd403ee3bbfa62ab572ac678b418b82cc7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a8d70c11c879828d16f44df2168853a5b709c8f7
Diff: https://reviews.apache.org/r/62101/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 62101: SENTRY-1916 Sentry should not store paths
outside of the prefix
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62101/#review184614
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 6, 2017, 12:54 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62101/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 12:54 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, and Vadim Spector.
>
>
> Bugs: SENTRY-1916
> https://issues.apache.org/jira/browse/SENTRY-1916
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1916 Sentry should not store paths outside of the prefix
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java 55092eec04d86b64aa91e30e76bb63c40b2a375b
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java 69e43fd651d8952f8a614e25e664a86bd1ba0248
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 551f184c35c8c3bf4e4b49aa540a55b016bb9a32
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java 478ccf9bb983dcb9d022eb03df8b90ba197fafb0
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java acf1cf5e2a9ba1cfaef9ccc404e56791c10b4be9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 63e718cd403ee3bbfa62ab572ac678b418b82cc7
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a8d70c11c879828d16f44df2168853a5b709c8f7
>
>
> Diff: https://reviews.apache.org/r/62101/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62101: SENTRY-1916 Sentry should not store paths
outside of the prefix
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62101/
-----------------------------------------------------------
(Updated Sept. 6, 2017, 12:54 a.m.)
Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, and Vadim Spector.
Changes
-------
Addressed comments from Vamsee - now only filter on the outbound path
Bugs: SENTRY-1916
https://issues.apache.org/jira/browse/SENTRY-1916
Repository: sentry
Description
-------
SENTRY-1916 Sentry should not store paths outside of the prefix
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java 55092eec04d86b64aa91e30e76bb63c40b2a375b
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java 69e43fd651d8952f8a614e25e664a86bd1ba0248
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 551f184c35c8c3bf4e4b49aa540a55b016bb9a32
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java 478ccf9bb983dcb9d022eb03df8b90ba197fafb0
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java acf1cf5e2a9ba1cfaef9ccc404e56791c10b4be9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 63e718cd403ee3bbfa62ab572ac678b418b82cc7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a8d70c11c879828d16f44df2168853a5b709c8f7
Diff: https://reviews.apache.org/r/62101/diff/2/
Changes: https://reviews.apache.org/r/62101/diff/1-2/
Testing
-------
Thanks,
Alexander Kolbasov