You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 08:46:59 UTC
[GitHub] [flink] ruanhang1993 opened a new pull request, #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema
ruanhang1993 opened a new pull request, #20164:
URL: https://github.com/apache/flink/pull/20164
## What is the purpose of the change
This pull request adds the close method to the interface KafkaRecordSerializationSchema.
## Brief change log
- Add the close method to the interface KafkaRecordSerializationSchema
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #20164:
URL: https://github.com/apache/flink/pull/20164#issuecomment-1758315173
@ruanhang1993 The Flink Kafka connector resides in it's own repository nowadays, if this code change is still relevant, please open the PR in https://github.com/apache/flink-connector-kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20164:
URL: https://github.com/apache/flink/pull/20164#issuecomment-1174805882
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a2bd1364c8c339bbc1dee47e30646c09dda966a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2bd1364c8c339bbc1dee47e30646c09dda966a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2bd1364c8c339bbc1dee47e30646c09dda966a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema
URL: https://github.com/apache/flink/pull/20164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mas-chen commented on a diff in pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema
Posted by GitBox <gi...@apache.org>.
mas-chen commented on code in PR #20164:
URL: https://github.com/apache/flink/pull/20164#discussion_r925068981
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchema.java:
##########
@@ -48,6 +48,12 @@ default void open(
SerializationSchema.InitializationContext context, KafkaSinkContext sinkContext)
throws Exception {}
+ /**
+ * Closes this kafka serialization schema and releases any system resources associated with it.
+ * If the stream is already closed then invoking this method has no effect.
+ */
+ default void close() throws Exception {}
Review Comment:
Shouldn't this be invoked by the source reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a diff in pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on code in PR #20164:
URL: https://github.com/apache/flink/pull/20164#discussion_r926303607
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchema.java:
##########
@@ -48,6 +48,12 @@ default void open(
SerializationSchema.InitializationContext context, KafkaSinkContext sinkContext)
throws Exception {}
+ /**
+ * Closes this kafka serialization schema and releases any system resources associated with it.
+ * If the stream is already closed then invoking this method has no effect.
+ */
+ default void close() throws Exception {}
Review Comment:
> Shouldn't this be invoked by the source reader?
You are right. I'll invoke close method in the `KafkaWriter`'s close method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org