You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "nkeywal (JIRA)" <ji...@apache.org> on 2012/06/28 09:51:44 UTC
[jira] [Created] (ZOOKEEPER-1495) ZK clieent hangs when using a
function not available on the server.
nkeywal created ZOOKEEPER-1495:
----------------------------------
Summary: ZK clieent hangs when using a function not available on the server.
Key: ZOOKEEPER-1495
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.3.5, 3.4.2
Environment: all
Reporter: nkeywal
Priority: Minor
This happens for example when using zk#multi with a 3.4 client but a 3.3 server.
The issue seems to be on the server side: the servers drops the packets with an unknown OpCode in ZooKeeperServer#submitRequest
{noformat}
public void submitRequest(Request si) {
// snip
try {
touch(si.cnxn);
boolean validpacket = Request.isValid(si.type); // ===> Check on case OpCode.*
if (validpacket) {
// snip
} else {
LOG.warn("Dropping packet at server of type " + si.type);
// if invalid packet drop the packet.
}
} catch (MissingSessionException e) {
if (LOG.isDebugEnabled()) {
LOG.debug("Dropping request: " + e.getMessage());
}
}
}
{noformat}
The solution discussed in ZOOKEEPER-1381 would be to get an exception on the client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1495) ZK clieent hangs when using a
function not available on the server.
Posted by "nkeywal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442347#comment-13442347 ]
nkeywal commented on ZOOKEEPER-1495:
------------------------------------
Any feedback on the patch proposed?
> ZK clieent hangs when using a function not available on the server.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1495
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.2, 3.3.5
> Environment: all
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 1495.br33.v3.patch
>
>
> This happens for example when using zk#multi with a 3.4 client but a 3.3 server.
> The issue seems to be on the server side: the servers drops the packets with an unknown OpCode in ZooKeeperServer#submitRequest
> {noformat}
> public void submitRequest(Request si) {
> // snip
> try {
> touch(si.cnxn);
> boolean validpacket = Request.isValid(si.type); // ===> Check on case OpCode.*
> if (validpacket) {
> // snip
> } else {
> LOG.warn("Dropping packet at server of type " + si.type);
> // if invalid packet drop the packet.
> }
> } catch (MissingSessionException e) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Dropping request: " + e.getMessage());
> }
> }
> }
> {noformat}
> The solution discussed in ZOOKEEPER-1381 would be to get an exception on the client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1495) ZK client hangs when using a
function not available on the server.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1495:
------------------------------------
Summary: ZK client hangs when using a function not available on the server. (was: ZK clieent hangs when using a function not available on the server.)
> ZK client hangs when using a function not available on the server.
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-1495
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.2, 3.3.5
> Environment: all
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 1495.br33.v3.patch
>
>
> This happens for example when using zk#multi with a 3.4 client but a 3.3 server.
> The issue seems to be on the server side: the servers drops the packets with an unknown OpCode in ZooKeeperServer#submitRequest
> {noformat}
> public void submitRequest(Request si) {
> // snip
> try {
> touch(si.cnxn);
> boolean validpacket = Request.isValid(si.type); // ===> Check on case OpCode.*
> if (validpacket) {
> // snip
> } else {
> LOG.warn("Dropping packet at server of type " + si.type);
> // if invalid packet drop the packet.
> }
> } catch (MissingSessionException e) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Dropping request: " + e.getMessage());
> }
> }
> }
> {noformat}
> The solution discussed in ZOOKEEPER-1381 would be to get an exception on the client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1495) ZK clieent hangs when using a
function not available on the server.
Posted by "nkeywal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated ZOOKEEPER-1495:
-------------------------------
Attachment: 1495.br33.v3.patch
> ZK clieent hangs when using a function not available on the server.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1495
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.2, 3.3.5
> Environment: all
> Reporter: nkeywal
> Priority: Minor
> Attachments: 1495.br33.v3.patch
>
>
> This happens for example when using zk#multi with a 3.4 client but a 3.3 server.
> The issue seems to be on the server side: the servers drops the packets with an unknown OpCode in ZooKeeperServer#submitRequest
> {noformat}
> public void submitRequest(Request si) {
> // snip
> try {
> touch(si.cnxn);
> boolean validpacket = Request.isValid(si.type); // ===> Check on case OpCode.*
> if (validpacket) {
> // snip
> } else {
> LOG.warn("Dropping packet at server of type " + si.type);
> // if invalid packet drop the packet.
> }
> } catch (MissingSessionException e) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Dropping request: " + e.getMessage());
> }
> }
> }
> {noformat}
> The solution discussed in ZOOKEEPER-1381 would be to get an exception on the client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1495) ZK clieent hangs when using a
function not available on the server.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1495:
---------------------------------------
Assignee: nkeywal
> ZK clieent hangs when using a function not available on the server.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1495
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1495
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.2, 3.3.5
> Environment: all
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 1495.br33.v3.patch
>
>
> This happens for example when using zk#multi with a 3.4 client but a 3.3 server.
> The issue seems to be on the server side: the servers drops the packets with an unknown OpCode in ZooKeeperServer#submitRequest
> {noformat}
> public void submitRequest(Request si) {
> // snip
> try {
> touch(si.cnxn);
> boolean validpacket = Request.isValid(si.type); // ===> Check on case OpCode.*
> if (validpacket) {
> // snip
> } else {
> LOG.warn("Dropping packet at server of type " + si.type);
> // if invalid packet drop the packet.
> }
> } catch (MissingSessionException e) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Dropping request: " + e.getMessage());
> }
> }
> }
> {noformat}
> The solution discussed in ZOOKEEPER-1381 would be to get an exception on the client side then & close the session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira