You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/12/12 05:38:11 UTC
[GitHub] zeppelin pull request #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1745
ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh
### What is this PR for?
We should remove `ZEPPELIN_NOTEBOOK_DIR` and `ZEPPELIN_INTERPRETER_DIR` from `common.sh` otherwise the corresponding property defined in `zeppelin-site.xml` won't take effect. I also check other properties like ZEPPELIN_CONF_DIR and ZEPPELIN_WAR. Although we define them explicitly in common.sh, we didn't expose them in document `install.md` and `zeppelin-site.xml.template`, so I think these are only for internal use and it is OK to keep them in common.sh although their correponding property in zeppelin-site.xml won't take effect too.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1785
### How should this be tested?
Tested manually
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
\u2026
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit 141ec68f98fd215664efb36506e1a38d295f461c
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-12-12T05:31:15Z
ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPEL...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1745
@Leemoonsoo Please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPEL...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1745
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPEL...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1745
Thanks @zjffdu for the fix!
LGTM and merge to master if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1745
ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh
### What is this PR for?
We should remove `ZEPPELIN_NOTEBOOK_DIR` and `ZEPPELIN_INTERPRETER_DIR` from `common.sh` otherwise the corresponding property defined in `zeppelin-site.xml` won't take effect. I also check other properties like ZEPPELIN_CONF_DIR and ZEPPELIN_WAR. Although we define them explicitly in common.sh, we didn't expose them in document `install.md` and `zeppelin-site.xml.template`, so I think these are only for internal use and it is OK to keep them in common.sh although their correponding property in zeppelin-site.xml won't take effect too.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1785
### How should this be tested?
Tested manually
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
\u2026
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1745
----
commit 141ec68f98fd215664efb36506e1a38d295f461c
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-12-12T05:31:15Z
ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---