You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/09/22 17:37:22 UTC

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

GitHub user mbalassi opened a pull request:

    https://github.com/apache/flink/pull/1168

    [utils] Missing getters for ParameterTool

    When using the `ParameterTool` I have found the `Boolean` getter missing, so added the missing functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbalassi/flink parametertool

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1168
    
----
commit 1b6e7ba19cc04dffb18903a58f5005a5d1529706
Author: mbalassi <mb...@apache.org>
Date:   2015-09-22T15:32:05Z

    [utils] Missing getters for ParameterTool

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1168#issuecomment-142857639
  
    Can you add tests for the methods? I think there is already a class with tests for all methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1168#issuecomment-143020279
  
    Great, thank you.
    
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

Posted by mbalassi <gi...@git.apache.org>.

Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/1168#issuecomment-142948084
  
    @rmetzger, sure, somehow I missed those tests. Now fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1168


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

Posted by chiwanpark <gi...@git.apache.org>.

Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1168#issuecomment-142482756
  
    Looks good to merge. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---