[jira] Commented: (ODE-846) Migration to Buildr 1.4 - hibernate handling

["Antoine Toulme (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ODE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878425#action_12878425 ] 

Antoine Toulme commented on ODE-846:
------------------------------------

Can't attach to jira today it seems, here is the patch inlined:

diff --git a/Rakefile b/Rakefile
index 9eb8cbd..b09cc8a 100644
--- a/Rakefile
+++ b/Rakefile
@@ -22,6 +22,9 @@ require "buildr/javacc"
 require "buildr/jetty"
 require "buildr/hibernate"
 
+Buildr::Hibernate::REQUIRES[:xdoclet] =  Buildr.group("xdoclet", "xdoclet-xdoclet-module", "xdoclet-hibernate-module",
+  :under=>"xdoclet", :version=>"1.2.3") + ["xdoclet:xjavadoc:jar:1.1-j5"]
+
 require File.join(File.dirname(__FILE__), 'repositories.rb')
 require File.join(File.dirname(__FILE__), 'dependencies.rb')
 
@@ -294,16 +297,12 @@ define "ode" do
     dao_hibernate = project("dao-hibernate").compile.target
     bpel_store = project("bpel-store").compile.target
 
-    Buildr::Hibernate::REQUIRES[:xdoclet] =  Buildr.group("xdoclet", "xdoclet-xdoclet-module", "xdoclet-hibernate-module",
+    hibernate_requires[:xdoclet] =  Buildr.group("xdoclet", "xdoclet-xdoclet-module", "xdoclet-hibernate-module",
       :under=>"xdoclet", :version=>"1.2.3") + ["xdoclet:xjavadoc:jar:1.1-j5"] + projects("dao-hibernate")
 
     export = lambda do |properties, source, target|
       file(target=>[properties, source]) do |task|
         mkpath File.dirname(target), :verbose=>false
-        # Protection against a buildr bug until the fix is released, avoids build failure
-
-        class << task ; attr_accessor :ant ; end
-        task.enhance { |task| task.ant = Buildr::Hibernate.schemaexport }
 
         hibernate_schemaexport target do |task, ant|
           ant.schemaexport(:properties=>properties.to_s, :quiet=>"yes", :text=>"yes", :delimiter=>";",

> Migration to Buildr 1.4 - hibernate handling
> --------------------------------------------
>
>                 Key: ODE-846
>                 URL: https://issues.apache.org/jira/browse/ODE-846
>             Project: ODE
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.3.4
>            Reporter: Antoine Toulme
>             Fix For: 1.3.5
>
>
> It sounds like your Rakefile is not handling well the lifecycle of the hibernate task. By setting part of the hibernate classpath as containing the result of the compilation of a project, you are creating a cycle.
> The attached patch will fix this problem when you move to Buildr 1.4.0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.