You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ram Ganesh <ra...@citrix.com> on 2013/07/10 09:28:50 UTC
Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response
of the API listLoadBalancerRuleInstances should show the service state of a
VM if health check is configured for it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/#review22950
-----------------------------------------------------------
Ship it!
Ship It!
- Ram Ganesh
On June 30, 2013, 6:08 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11858/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 6:08 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, and Vijay Venkatachalam.
>
>
> Bugs: CLOUDSTACK-2340
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue: when healthcheck is created for LB rule then listLoadBalancerRuleInstance api should have the service state populated by LBHealthCheckManager.
> Fixed: Fixed the response of listLoadBalancerRuleInstance to include a "servicestate":"UP" which tell the service state of the instance.
> if the healthcheck is not created on LB then api response then "servicestate" field won't be in the response.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3
> api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java 49ab42c
> api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 67d31ab
>
> Diff: https://reviews.apache.org/r/11858/diff/
>
>
> Testing
> -------
>
> 1. Created LB rule with healthcheck policy verified the listLoadBalancerRuleInstance api response, it has the field servicestate for all the VM's assigned to the LB rule
> 2. Created LB rule without healthcheck policy, verified the listLoadBalancerRuleInstance api response wont have the servicestate field for all the VM's assigned to the LB rule
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response
of the API listLoadBalancerRuleInstances should show the service state of a
VM if health check is configured for it
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 10, 2013, 7:28 a.m., Ram Ganesh wrote:
> > Ship It!
Thanks for the review.
I have to rebase with latest head and then post the patch again.
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/#review22950
-----------------------------------------------------------
On June 30, 2013, 6:08 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11858/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 6:08 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, and Vijay Venkatachalam.
>
>
> Bugs: CLOUDSTACK-2340
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue: when healthcheck is created for LB rule then listLoadBalancerRuleInstance api should have the service state populated by LBHealthCheckManager.
> Fixed: Fixed the response of listLoadBalancerRuleInstance to include a "servicestate":"UP" which tell the service state of the instance.
> if the healthcheck is not created on LB then api response then "servicestate" field won't be in the response.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3
> api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java 49ab42c
> api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 67d31ab
>
> Diff: https://reviews.apache.org/r/11858/diff/
>
>
> Testing
> -------
>
> 1. Created LB rule with healthcheck policy verified the listLoadBalancerRuleInstance api response, it has the field servicestate for all the VM's assigned to the LB rule
> 2. Created LB rule without healthcheck policy, verified the listLoadBalancerRuleInstance api response wont have the servicestate field for all the VM's assigned to the LB rule
>
>
> Thanks,
>
> Rajesh Battala
>
>